qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: seabios@seabios.org, kevin@koconnor.net
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] seabios bug: fail to find etc/boot-fail-wait
Date: Mon, 4 Mar 2013 17:45:02 +0800	[thread overview]
Message-ID: <20130304094502.GA10725@t430s.nay.redhat.com> (raw)

./qemu-upstream-latest -boot reboot-timeout=1000 ...
(after boot failed, VM waits for 1000 ms and try to reboot)


reboot-timeout parameter doesn't work now, I found this regression bug
was introduced by commit 59d6ca52a7eba5b1f4f2becf70fd446dccaf0a2e

> Author: Kevin O'Connor <kevin@koconnor.net>
> Date:   Thu May 31 00:20:55 2012 -0400
> 
>     Cache romfile entries.
>     
>     Create a 'struct romfile_s' and populate a list of all romfiles at
>     start of init.  Caching the romfiles both simplifies the code and
>     makes it more efficient.
>     
>     Also, convert the ramdisk code to use romfile helpers instead of
>     directly accessing cbfs.

romfile_add() is used to add rom files in the list.
When seabios calls boot_fail(), the list becomes empty,
romfile_find("etc/boot-fail-wait", ..) returns NULL.
it seems the list items are released prematurely.

Thanks, Amos

             reply	other threads:[~2013-03-04  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04  9:45 Amos Kong [this message]
2013-03-04 13:53 ` [Qemu-devel] seabios bug: fail to find etc/boot-fail-wait Kevin O'Connor
2013-03-05  2:06 ` [Qemu-devel] [Seabios PATCH] make reboot-timeout to static for using it after POST phase Amos Kong
2013-03-05  9:03   ` [Qemu-devel] [SeaBIOS] " li guang
2013-03-05  9:52 ` [Qemu-devel] [Seabios PATCH v2] " Amos Kong
2013-03-07  1:07   ` Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130304094502.GA10725@t430s.nay.redhat.com \
    --to=akong@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).