From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, patches@linaro.org,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci_host: Drop write-only address_space field
Date: Mon, 4 Mar 2013 11:58:00 +0100 [thread overview]
Message-ID: <20130304105800.GD2837@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1362157061-438-1-git-send-email-peter.maydell@linaro.org>
On Fri, Mar 01, 2013 at 04:57:41PM +0000, Peter Maydell wrote:
> The address_space field of PCIHostState was only ever written, never used.
> Drop it completely.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Noticed this when looking at converting versatile_pci to be a subclass
> of pci_host; it's nice to be able to drop the ugly fishing around in
> the object struct that the two users here were doing...
>
> hw/pci/pci_host.h | 1 -
> hw/piix_pci.c | 1 -
> hw/ppc/prep.c | 1 -
> 3 files changed, 3 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2013-03-04 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 16:57 [Qemu-devel] [PATCH] pci_host: Drop write-only address_space field Peter Maydell
2013-03-01 18:33 ` Andreas Färber
2013-03-01 18:50 ` Peter Maydell
2013-03-01 18:57 ` Andreas Färber
2013-03-04 10:58 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304105800.GD2837@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).