From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCT5t-0005OT-K3 for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:58:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCT5o-0003kh-Og for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:58:09 -0500 Date: Mon, 4 Mar 2013 11:58:00 +0100 From: Stefan Hajnoczi Message-ID: <20130304105800.GD2837@stefanha-thinkpad.redhat.com> References: <1362157061-438-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362157061-438-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci_host: Drop write-only address_space field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, patches@linaro.org, qemu-devel@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , "Michael S. Tsirkin" On Fri, Mar 01, 2013 at 04:57:41PM +0000, Peter Maydell wrote: > The address_space field of PCIHostState was only ever written, never used. > Drop it completely. > > Signed-off-by: Peter Maydell > --- > Noticed this when looking at converting versatile_pci to be a subclass > of pci_host; it's nice to be able to drop the ugly fishing around in > the object struct that the two users here were doing... > > hw/pci/pci_host.h | 1 - > hw/piix_pci.c | 1 - > hw/ppc/prep.c | 1 - > 3 files changed, 3 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan