From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53302)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UCV2C-00071i-90
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 08:02:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UCV2B-000529-7F
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 08:02:28 -0500
Received: from mail-bk0-f46.google.com ([209.85.214.46]:63052)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UCV2B-000524-0F
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 08:02:27 -0500
Received: by mail-bk0-f46.google.com with SMTP id j5so2358654bkw.5
	for <qemu-devel@nongnu.org>; Mon, 04 Mar 2013 05:02:26 -0800 (PST)
Date: Mon, 4 Mar 2013 14:02:22 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130304130222.GB18476@stefanha-thinkpad.redhat.com>
References: <1361875228-15769-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1361875228-15769-10-git-send-email-xiawenc@linux.vnet.ibm.com>
	<874ngxhhfv.fsf@blackfin.pond.sub.org>
	<20130227162229.GJ2514@dhcp-200-207.str.redhat.com>
	<513009B9.4090406@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <513009B9.4090406@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find()
 to block.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, lcapitulino@redhat.com, pbonzini@redhat.com

On Fri, Mar 01, 2013 at 09:51:53AM +0800, Wenchao Xia wrote: > 于 2013-2-28 0:22, Kevin Wolf 写道:
> >Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:
> >>Wenchao Xia <xiawenc@linux.vnet.ibm.com> writes:
> >>
> >>>Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> >>>Reviewed-by: Eric Blake <eblake@redhat.com>
> >>>---
> >>>  block.c               |   24 ++++++++++++++++++++++++
> >>>  include/block/block.h |    2 ++
> >>>  savevm.c              |   22 ----------------------
> >>>  3 files changed, 26 insertions(+), 22 deletions(-)
> >>
> >>Perhaps savevm.c isn't the best home for snapshot stuff, but I don't
> >>like it in block.c any better.  block.c is already unwieldy, and I'd
> >>like us to try limiting it to core block stuff.
> >>
> >>Kevin, Stefan, any ideas?
> >
> >Take some more snapshot related functions from block.c and move them to
> >block/snapshot.c?
> >
> >Kevin
> >
> Hi, Stefan
>   Do you also agree about adding new file block/snapshot.c?

Yes, I agree.

Stefan