From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCVTd-0008Jw-GG for qemu-devel@nongnu.org; Mon, 04 Mar 2013 08:30:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCVTX-0004tP-5M for qemu-devel@nongnu.org; Mon, 04 Mar 2013 08:30:49 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:60858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCVTW-0004tD-SH for qemu-devel@nongnu.org; Mon, 04 Mar 2013 08:30:42 -0500 From: Paul Brook Date: Mon, 4 Mar 2013 13:30:37 +0000 References: <1362158507-19310-1-git-send-email-chouteau@adacore.com> <201303012051.17503.paul@codesourcery.com> <5134716C.9020001@adacore.com> In-Reply-To: <5134716C.9020001@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-ID: <201303041330.37991.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH 3/4] target-arm: Fix VFP register byte order in GDB remote List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de > >> "The bytes with the register are transmitted in target byte order." > >> > >> /* Aliases for Q regs. */ > >> nregs += 16; > >> if (reg < nregs) { > >> > >> - stfq_le_p(buf, env->vfp.regs[(reg - 32) * 2]); > >> - stfq_le_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]); > >> + stfq_p(buf, env->vfp.regs[(reg - 32) * 2]); > >> + stfq_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]); > > > > This is wrong. You're still using little-endian ordering of words. > > Can you explain a little bit further? If I'm in big-endian mode, stfq_p() > will be stfq_be_p(), right? Because we're actually storing two halves of a 128-bit value. You still store the least significant half first. Paul