From: Stefan Hajnoczi <stefanha@gmail.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Richa Marwaha <rmarwah@linux.vnet.ibm.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Corey Bryant <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 2/2] bridge helper: support conf dirs
Date: Tue, 5 Mar 2013 10:19:23 +0100 [thread overview]
Message-ID: <20130305091923.GA1938@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1362207528-27804-3-git-send-email-cardoe@cardoe.com>
On Sat, Mar 02, 2013 at 12:58:48AM -0600, Doug Goldstein wrote:
> @@ -152,6 +199,14 @@ static int parse_acl_file(const char *filename, ACLList *acl_list)
> failure:
> fclose(f);
>
> + if (include_list) {
> + for (i = 0; i < include_count; i++) {
> + if (include_list[i])
> + free(include_list[i]);
free(NULL) is a nop so the if isn't necessary - you can
free(include_list[i]) unconditionally.
next prev parent reply other threads:[~2013-03-05 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361757620-23318-1-git-send-email-cardoe@cardoe.com>
2013-03-02 6:58 ` [Qemu-devel] [PATCHv2 0/2] bridge helper: includedir conf arg Doug Goldstein
2013-03-02 6:58 ` [Qemu-devel] [PATCHv2 1/2] bridge helper: unified error cleanup for parse_acl_file Doug Goldstein
2013-03-04 16:27 ` Corey Bryant
2013-03-04 18:53 ` Doug Goldstein
2013-03-04 19:04 ` Corey Bryant
2013-03-02 6:58 ` [Qemu-devel] [PATCHv2 2/2] bridge helper: support conf dirs Doug Goldstein
2013-03-04 16:40 ` Corey Bryant
2013-03-05 9:19 ` Stefan Hajnoczi [this message]
2013-03-07 6:32 ` [Qemu-devel] [PATCHv3 0/2] bridge helper: includedir conf arg Doug Goldstein
2013-03-07 6:32 ` [Qemu-devel] [PATCHv3 1/2] bridge helper: unified error cleanup for parse_acl_file Doug Goldstein
2013-03-07 6:32 ` [Qemu-devel] [PATCHv3 2/2] bridge helper: support conf dirs Doug Goldstein
2013-03-09 9:50 ` Blue Swirl
2013-03-07 9:10 ` [Qemu-devel] [PATCHv3 0/2] bridge helper: includedir conf arg Stefan Hajnoczi
2013-03-07 15:11 ` Corey Bryant
2013-03-18 4:17 ` [Qemu-devel] [PATCH v3 " Doug Goldstein
2013-03-18 4:17 ` [Qemu-devel] [PATCH v3 1/2] bridge helper: unified error cleanup for parse_acl_file Doug Goldstein
2013-03-18 4:17 ` [Qemu-devel] [PATCH v3 2/2] bridge helper: support conf dirs Doug Goldstein
2013-03-18 10:01 ` [Qemu-devel] [PATCH v3 0/2] bridge helper: includedir conf arg Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305091923.GA1938@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=cardoe@cardoe.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rmarwah@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).