From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UCo1x-0008Rg-SN
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 04:19:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UCo1w-0004PG-T9
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 04:19:29 -0500
Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:57162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UCo1w-0004Oy-NK
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 04:19:28 -0500
Received: by mail-we0-f182.google.com with SMTP id t57so5851512wey.13
	for <qemu-devel@nongnu.org>; Tue, 05 Mar 2013 01:19:27 -0800 (PST)
Date: Tue, 5 Mar 2013 10:19:23 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130305091923.GA1938@stefanha-thinkpad.redhat.com>
References: <1361757620-23318-1-git-send-email-cardoe@cardoe.com>
	<1362207528-27804-1-git-send-email-cardoe@cardoe.com>
	<1362207528-27804-3-git-send-email-cardoe@cardoe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1362207528-27804-3-git-send-email-cardoe@cardoe.com>
Subject: Re: [Qemu-devel] [PATCHv2 2/2] bridge helper: support conf dirs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Richa Marwaha <rmarwah@linux.vnet.ibm.com>, Anthony Liguori <aliguori@us.ibm.com>, Corey Bryant <coreyb@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Sat, Mar 02, 2013 at 12:58:48AM -0600, Doug Goldstein wrote:
> @@ -152,6 +199,14 @@ static int parse_acl_file(const char *filename, ACLList *acl_list)
>  failure:
>      fclose(f);
>  
> +    if (include_list) {
> +        for (i = 0; i < include_count; i++) {
> +            if (include_list[i])
> +                free(include_list[i]);

free(NULL) is a nop so the if isn't necessary - you can
free(include_list[i]) unconditionally.