* [Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size
@ 2012-12-02 21:00 Marc-André Lureau
2013-01-14 16:18 ` Marc-André Lureau
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2012-12-02 21:00 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, alevy, kraxel
The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only.
pcsc_scan was complaining before the patch:
+ Historical bytes: 56 43 41 52 44 5F 4E 53 53
ERROR! ATR is truncated: 2 byte(s) is/are missing
---
libcacard/vcardt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
index d3e9522..538bdde 100644
--- a/libcacard/vcardt.h
+++ b/libcacard/vcardt.h
@@ -26,7 +26,7 @@ typedef struct VCardEmulStruct VCardEmul;
#define MAX_CHANNEL 4
/* create an ATR with appropriate historical bytes */
-#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
+#define VCARD_ATR_PREFIX(size) 0x3b, 0x66+(size), 0x00, 0xff, \
'V', 'C', 'A', 'R', 'D', '_'
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size
2012-12-02 21:00 [Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size Marc-André Lureau
@ 2013-01-14 16:18 ` Marc-André Lureau
[not found] ` <CAJ+F1CJbSSKqRzZmVoT4=Jw9g4Kqg6P_W_JuPxyHatshggMQag@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2013-01-14 16:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, Alon Levy, Gerd Hoffmann
ping
On Sun, Dec 2, 2012 at 10:00 PM, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only.
>
> pcsc_scan was complaining before the patch:
>
> + Historical bytes: 56 43 41 52 44 5F 4E 53 53
> ERROR! ATR is truncated: 2 byte(s) is/are missing
> ---
> libcacard/vcardt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> index d3e9522..538bdde 100644
> --- a/libcacard/vcardt.h
> +++ b/libcacard/vcardt.h
> @@ -26,7 +26,7 @@ typedef struct VCardEmulStruct VCardEmul;
> #define MAX_CHANNEL 4
>
> /* create an ATR with appropriate historical bytes */
> -#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
> +#define VCARD_ATR_PREFIX(size) 0x3b, 0x66+(size), 0x00, 0xff, \
> 'V', 'C', 'A', 'R', 'D', '_'
>
>
> --
> 1.7.11.7
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size
[not found] ` <CAJ+F1CJbSSKqRzZmVoT4=Jw9g4Kqg6P_W_JuPxyHatshggMQag@mail.gmail.com>
@ 2013-03-05 16:11 ` Alon Levy
0 siblings, 0 replies; 3+ messages in thread
From: Alon Levy @ 2013-03-05 16:11 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Marc-André Lureau, qemu-devel, Gerd Hoffmann
On Tue, Feb 26, 2013 at 01:58:36PM +0100, Marc-André Lureau wrote:
> ping
Works, thanks.
Reviewed-by: Alon Levy <alevy@redhat.com>
>
> On Mon, Jan 14, 2013 at 5:18 PM, Marc-André Lureau
> <marcandre.lureau@gmail.com> wrote:
> > ping
> >
> > On Sun, Dec 2, 2012 at 10:00 PM, Marc-André Lureau
> > <marcandre.lureau@gmail.com> wrote:
> >> The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only.
> >>
> >> pcsc_scan was complaining before the patch:
> >>
> >> + Historical bytes: 56 43 41 52 44 5F 4E 53 53
> >> ERROR! ATR is truncated: 2 byte(s) is/are missing
> >> ---
> >> libcacard/vcardt.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> >> index d3e9522..538bdde 100644
> >> --- a/libcacard/vcardt.h
> >> +++ b/libcacard/vcardt.h
> >> @@ -26,7 +26,7 @@ typedef struct VCardEmulStruct VCardEmul;
> >> #define MAX_CHANNEL 4
> >>
> >> /* create an ATR with appropriate historical bytes */
> >> -#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
> >> +#define VCARD_ATR_PREFIX(size) 0x3b, 0x66+(size), 0x00, 0xff, \
> >> 'V', 'C', 'A', 'R', 'D', '_'
> >>
> >>
> >> --
> >> 1.7.11.7
> >>
> >
> >
> >
> > --
> > Marc-André Lureau
>
>
>
> --
> Marc-André Lureau
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-05 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-02 21:00 [Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size Marc-André Lureau
2013-01-14 16:18 ` Marc-André Lureau
[not found] ` <CAJ+F1CJbSSKqRzZmVoT4=Jw9g4Kqg6P_W_JuPxyHatshggMQag@mail.gmail.com>
2013-03-05 16:11 ` Alon Levy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).