From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDB5N-0006br-DI for qemu-devel@nongnu.org; Wed, 06 Mar 2013 04:56:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDB5M-0001vw-12 for qemu-devel@nongnu.org; Wed, 06 Mar 2013 04:56:33 -0500 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:51856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDB5L-0001vo-RQ for qemu-devel@nongnu.org; Wed, 06 Mar 2013 04:56:31 -0500 Received: by mail-we0-f172.google.com with SMTP id d46so3497850wer.3 for ; Wed, 06 Mar 2013 01:56:31 -0800 (PST) Date: Wed, 6 Mar 2013 10:56:25 +0100 From: Stefan Hajnoczi Message-ID: <20130306095625.GB1954@stefanha-thinkpad.muc.redhat.com> References: <1362477081-31843-1-git-send-email-lilei@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362477081-31843-1-git-send-email-lilei@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] osdep: pass const char pointer to setsockopt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: mdroh@linux.vnet.ibm.com, qemu-devel@nongnu.org On Tue, Mar 05, 2013 at 05:51:21PM +0800, Lei Li wrote: > Pass the right type for setsockopt(), and this will also > fix the compiler warning when cross build for qemu-ga.exe: > > util/osdep.c: In function 'socket_set_nodelay': > util/osdep.c:69:5: warning: passing argument 4 of 'setsockopt' from > incompatible pointer type [enabled by default] > In file included from /home/lei/qemu_b/include/sysemu/os-win32.h:30:0, > from /home/lei/qemu_b/include/qemu-common.h:46, > from util/osdep.c:48: > /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:990:63: note: > expected 'const char *' but argument is of type 'int *' > > Signed-off-by: Lei Li > --- > util/osdep.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/util/osdep.c b/util/osdep.c > index c408261..ce472a9 100644 > --- a/util/osdep.c > +++ b/util/osdep.c > @@ -57,7 +57,7 @@ static const char *qemu_version = QEMU_VERSION; > int socket_set_cork(int fd, int v) > { > #if defined(SOL_TCP) && defined(TCP_CORK) > - return setsockopt(fd, SOL_TCP, TCP_CORK, &v, sizeof(v)); > + return setsockopt(fd, SOL_TCP, TCP_CORK, (char *)&v, sizeof(v)); > #else > return 0; > #endif > @@ -66,7 +66,7 @@ int socket_set_cork(int fd, int v) > int socket_set_nodelay(int fd) > { > int v = 1; > - return setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &v, sizeof(v)); > + return setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, (char *)&v, sizeof(v)); Please use qemu_setsockopt() instead of open-coding this. Stefan