From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDe5h-0007vU-Mp for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:54:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDe5e-0005eq-PC for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:54:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDe5e-0005ed-Fz for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:54:46 -0500 Date: Thu, 7 Mar 2013 18:49:39 +0200 From: "Michael S. Tsirkin" Message-ID: <20130307164938.GA29702@redhat.com> References: <1360108037-9211-1-git-send-email-jlarrew@linux.vnet.ibm.com> <1360108037-9211-3-git-send-email-jlarrew@linux.vnet.ibm.com> <513621F7.9030403@suse.de> <51362575.2000908@de.ibm.com> <87621319kc.fsf@codemonkey.ws> <5138C007.6080305@de.ibm.com> <5138C26B.5010408@suse.de> <87txon6ty5.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <87txon6ty5.fsf@codemonkey.ws> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Hajnoczi , Jesse Larrew , Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , Jens Freimann , Cornelia Huck , Andreas =?iso-8859-1?Q?F=E4rber?= On Thu, Mar 07, 2013 at 10:44:18AM -0600, Anthony Liguori wrote: > Andreas F=E4rber writes: >=20 > > Am 07.03.2013 17:27, schrieb Christian Borntraeger: > >>> It's a bug in both virtio-ccw that features=3D0 when get_features i= s > >>> called. You can also tell this with: > >>> > >>> [10:02 AM] anthony@titi:~/git/qemu/hw/s390x$ grep DEFINE_VIRTIO_NET= _FEATURES * > >>> virtio-ccw.c: DEFINE_VIRTIO_NET_FEATURES(VirtioCcwDevice, host_f= eatures[0]), > >>> > >>> So virtio-s390 is doing it wrong, but virtio-ccw looks like its doi= ng it > >>> right. > >>=20 > >> At least, this patch seems to work. (That also implies, that a trans= port > >> must not hide virtio feature bits). > > > > To me it indicates that the use of the old qdev property setters is > > hiding errors resulting from trying to set not-existing properties. > > If we would set the properties in a way that gets us an Error* on > > failure like the object_property_set_*() do, we would notice on machi= ne > > creation (or device_add). >=20 > Hrm, I don't understand your statement. >=20 > Can you elaborate? >=20 > Regards, >=20 > Anthony Liguori Well to me this indicates that s390 virtio is buggy. It's not supposed to crash whatever set of features we specify. > > > > Andreas > > > >>=20 > >>=20 > >> From: Christian Borntraeger > >> Date: Thu, 7 Mar 2013 17:21:41 +0100 > >> Subject: [PATCH] Allow virtio-net features for legacy s390 virtio bu= s > >>=20 > >> Enable all virtio-net features for the legacy s390 virtio bus. > >> This also fixes > >> kernel BUG at /usr/src/packages/BUILD/kernel-default-3.0.58/linux-3.= 0/drivers/s390/kvm/kvm_virtio.c:121! > >>=20 > >> Signed-off-by: Christian Borntraeger > >> --- > >> hw/s390x/s390-virtio-bus.c | 1 + > >> 1 file changed, 1 insertion(+) > >>=20 > >> diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c > >> index 1200691..a8a8e19 100644 > >> --- a/hw/s390x/s390-virtio-bus.c > >> +++ b/hw/s390x/s390-virtio-bus.c > >> @@ -399,6 +399,7 @@ static const VirtIOBindings virtio_s390_bindings= =3D { > >> =20 > >> static Property s390_virtio_net_properties[] =3D { > >> DEFINE_NIC_PROPERTIES(VirtIOS390Device, nic), > >> + DEFINE_VIRTIO_NET_FEATURES(VirtIOS390Device, host_features), > >> DEFINE_PROP_UINT32("x-txtimer", VirtIOS390Device, > >> net.txtimer, TX_TIMER_INTERVAL), > >> DEFINE_PROP_INT32("x-txburst", VirtIOS390Device, > >>=20 > > > > > > --=20 > > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FC= rnberg