From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDgO9-0004VO-EM for qemu-devel@nongnu.org; Thu, 07 Mar 2013 14:22:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDgO6-0003pn-Kf for qemu-devel@nongnu.org; Thu, 07 Mar 2013 14:22:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDgO6-0003pY-DW for qemu-devel@nongnu.org; Thu, 07 Mar 2013 14:21:58 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r27JLvII022207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Mar 2013 14:21:57 -0500 Date: Thu, 7 Mar 2013 21:22:16 +0200 From: "Michael S. Tsirkin" Message-ID: <20130307192216.GA12692@redhat.com> References: <20130307182932.22161.62817.stgit@bling.home> <20130307184930.GB31034@redhat.com> <1362683831.22132.135.camel@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362683831.22132.135.camel@bling.home> Subject: Re: [Qemu-devel] [PATCH] xio3130: Add map_irq functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org On Thu, Mar 07, 2013 at 12:17:11PM -0700, Alex Williamson wrote: > On Thu, 2013-03-07 at 20:49 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 11:29:46AM -0700, Alex Williamson wrote: > > > Just like root ports, I think these are supposed to be direct mapped. > > > > > > Signed-off-by: Alex Williamson > > > > Hmm, very strange. Why not using standard pci bridge logic? > > Any idea? > > Where is it supposed to get set for a bridge? I see: > > int pci_bridge_initfn(PCIDevice *dev) > { > ... > sec_bus->map_irq = br->map_irq; > > But nobody is calling pci_bridge_map_irq() to set that, so that's what I > added. Thanks, > > Alex Yes but shouldn't this be using standard PCI mapping, like pci_bridge_dev_map_irq_fn in pci_bridge_dev? We really should make it the default if nothing is set ... > > > --- > > > hw/xio3130_downstream.c | 7 +++++++ > > > hw/xio3130_upstream.c | 7 +++++++ > > > 2 files changed, 14 insertions(+) > > > > > > diff --git a/hw/xio3130_downstream.c b/hw/xio3130_downstream.c > > > index 7f00bc8..c484770 100644 > > > --- a/hw/xio3130_downstream.c > > > +++ b/hw/xio3130_downstream.c > > > @@ -54,6 +54,11 @@ static void xio3130_downstream_reset(DeviceState *qdev) > > > pci_bridge_reset(qdev); > > > } > > > > > > +static int xio3130_downstream_map_irq(PCIDevice *pci_dev, int irq_num) > > > +{ > > > + return irq_num; > > > +} > > > + > > > static int xio3130_downstream_initfn(PCIDevice *d) > > > { > > > PCIBridge* br = DO_UPCAST(PCIBridge, dev, d); > > > @@ -61,6 +66,8 @@ static int xio3130_downstream_initfn(PCIDevice *d) > > > PCIESlot *s = DO_UPCAST(PCIESlot, port, p); > > > int rc; > > > > > > + pci_bridge_map_irq(br, NULL, xio3130_downstream_map_irq); > > > + > > > rc = pci_bridge_initfn(d); > > > if (rc < 0) { > > > return rc; > > > diff --git a/hw/xio3130_upstream.c b/hw/xio3130_upstream.c > > > index 70b15d3..c233a43 100644 > > > --- a/hw/xio3130_upstream.c > > > +++ b/hw/xio3130_upstream.c > > > @@ -51,12 +51,19 @@ static void xio3130_upstream_reset(DeviceState *qdev) > > > pcie_cap_deverr_reset(d); > > > } > > > > > > +static int xio3130_upstream_map_irq(PCIDevice *pci_dev, int irq_num) > > > +{ > > > + return irq_num; > > > +} > > > + > > > static int xio3130_upstream_initfn(PCIDevice *d) > > > { > > > PCIBridge* br = DO_UPCAST(PCIBridge, dev, d); > > > PCIEPort *p = DO_UPCAST(PCIEPort, br, br); > > > int rc; > > > > > > + pci_bridge_map_irq(br, NULL, xio3130_upstream_map_irq); > > > + > > > rc = pci_bridge_initfn(d); > > > if (rc < 0) { > > > return rc; > >