From: Stefan Hajnoczi <stefanha@gmail.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] rtc-test: Fix test failures with recent glib
Date: Fri, 8 Mar 2013 10:17:38 +0100 [thread overview]
Message-ID: <20130308091738.GB9597@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <4cef3fca4cde08008905c89cc2b73069e67824bc.1361925092.git.crobinso@redhat.com>
On Tue, Feb 26, 2013 at 07:31:32PM -0500, Cole Robinson wrote:
> As of glib 2.35.4, glib changed its logic for ordering test cases:
>
> https://bugzilla.gnome.org/show_bug.cgi?id=694487
>
> This was causing failures in rtc-test. Group the reordered test
> cases into their own suite, which maintains the original ordering.
>
> CC: qemu-stable@nongnu.org
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> tests/rtc-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
It's best to make test cases independent of order (no side-effects), but
this small patch fixes the problem.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
parent reply other threads:[~2013-03-08 9:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4cef3fca4cde08008905c89cc2b73069e67824bc.1361925092.git.crobinso@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308091738.GB9597@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).