From: Stefan Hajnoczi <stefanha@gmail.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] osdep: replace setsockopt by qemu_setsockopt
Date: Fri, 8 Mar 2013 10:22:23 +0100 [thread overview]
Message-ID: <20130308092223.GA9978@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1362580156-11498-1-git-send-email-lilei@linux.vnet.ibm.com>
On Wed, Mar 06, 2013 at 10:29:16PM +0800, Lei Li wrote:
> Fix the compiler warning when cross build qemu-ga
> for windows by using qemu_setsockopt() instead of
> setsockopt().
>
> util/osdep.c: In function 'socket_set_nodelay':
> util/osdep.c:69:5: warning: passing argument 4 of 'setsockopt' from
> incompatible pointer type [enabled by default]
> In file included from /home/lei/qemu_b/include/sysemu/os-win32.h:30:0,
> from /home/lei/qemu_b/include/qemu-common.h:46,
> from util/osdep.c:48:
> /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:990:63: note:
> expected 'const char *' but argument is of type 'int *'
>
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>
> Change since v1:
> - Use qemu_setsockopt() instead of open-coding suggested by Stefan.
>
> ---
> util/osdep.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2013-03-08 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 14:29 [Qemu-devel] [PATCH v2] osdep: replace setsockopt by qemu_setsockopt Lei Li
2013-03-08 9:22 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308092223.GA9978@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).