From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UDtVW-0003VF-HW
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:22:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UDtVS-00084r-Cy
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:22:30 -0500
Received: from mail-wg0-f43.google.com ([74.125.82.43]:42997)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UDtVS-00084f-7E
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:22:26 -0500
Received: by mail-wg0-f43.google.com with SMTP id e12so2255970wge.10
	for <qemu-devel@nongnu.org>; Fri, 08 Mar 2013 01:22:25 -0800 (PST)
Date: Fri, 8 Mar 2013 10:22:23 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130308092223.GA9978@stefanha-thinkpad.redhat.com>
References: <1362580156-11498-1-git-send-email-lilei@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1362580156-11498-1-git-send-email-lilei@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] osdep: replace setsockopt by
	qemu_setsockopt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Wed, Mar 06, 2013 at 10:29:16PM +0800, Lei Li wrote:
> Fix the compiler warning when cross build qemu-ga
> for windows by using qemu_setsockopt() instead of
> setsockopt().
> 
> util/osdep.c: In function 'socket_set_nodelay':
> util/osdep.c:69:5: warning: passing argument 4 of 'setsockopt' from
>                    incompatible pointer type [enabled by default]
> In file included from /home/lei/qemu_b/include/sysemu/os-win32.h:30:0,
>                  from /home/lei/qemu_b/include/qemu-common.h:46,
>                  from util/osdep.c:48:
> /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:990:63: note:
>                  expected 'const char *' but argument is of type 'int *'
> 
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
> 
> Change since v1:
>   - Use qemu_setsockopt() instead of open-coding suggested by Stefan.
> 
> ---
>  util/osdep.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan