From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52043)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UDtjg-00045M-43
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:37:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UDtje-0004Z4-SP
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:37:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56416)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UDtje-0004Yx-Kf
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:37:06 -0500
Date: Fri, 8 Mar 2013 10:35:19 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130308093519.GA4573@dhcp-200-207.str.redhat.com>
References: <513785A0.1010001@redhat.com>
	<20130306181454.GB3743@localhost.localdomain>
	<51378B97.2000709@redhat.com>
	<20130306184800.GB22782@localhost.localdomain>
	<51379304.50307@dlhnet.de> <5137A964.5020803@redhat.com>
	<513855A7.7070205@dlhnet.de> <5138BBA7.5030903@redhat.com>
	<51399911.1060006@dlhnet.de> <5139AE29.9020106@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5139AE29.9020106@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/7] block: only force IO completion in
 .bdrv_truncate if we are shrinking
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: sw@weilnetz.de, Jeff Cody <jcody@redhat.com>, Peter Lieven <pl@dlhnet.de>, qemu-devel@nongnu.org, stefanha@redhat.com

Am 08.03.2013 um 10:23 hat Paolo Bonzini geschrieben:
> Il 08/03/2013 08:53, Peter Lieven ha scritto:
> >>
> >> I think the fix is to only call it for the monitor command.  Optionally,
> >> when shrinking, assert that there are no requests in flight.
> > 
> > Okay.
> > 
> > What is the plan? just fix this or fix the whole thing (which seems to
> > be some
> > work).
> > 
> > The suggested patch from Jeff will break iscsi_truncate as bs->growable
> > is 1 currently.
> 
> I guess it's up to Kevin and Jeff.

Someone needs to send a fix for the qcow1 (and probably vmdk)
regression, otherwise I'll have to revert the patch.

Kevin