From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDuIw-0002X2-5q for qemu-devel@nongnu.org; Fri, 08 Mar 2013 05:13:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDuIu-0000J1-Qg for qemu-devel@nongnu.org; Fri, 08 Mar 2013 05:13:34 -0500 Date: Fri, 8 Mar 2013 11:13:24 +0100 From: Stefan Hajnoczi Message-ID: <20130308101324.GA32107@stefanha-thinkpad.redhat.com> References: <20130307033301.GA48996@cs.nctu.edu.tw> <20130308092102.GD9597@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Use proper term in TCG README List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= On Fri, Mar 08, 2013 at 05:29:29PM +0800, Peter Maydell wrote: > On 8 March 2013 17:21, Stefan Hajnoczi wrote: > > On Thu, Mar 07, 2013 at 11:33:01AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > >> In TCG, "target" means the host architecture for which TCG generates the > >> code. Using "guest" rather than "target" to make the document more consistent. > > >> @@ -379,7 +379,7 @@ double-word product T0. The later is returned in two single-word outputs. > >> > >> Similar to mulu2, except the two inputs T1 and T2 are signed. > >> > >> -********* 64-bit target on 32-bit host support > >> +********* 64-bit guest on 32-bit host support > >> > >> The following opcodes are internal to TCG. Thus they are to be implemented by > >> 32-bit host code generators, but are not to be emitted by guest translators. > > > > Review from TCG experts please. > > > > It seems we have multiple meanings for "target" (e.g. ./configure > > --target-list= does not mean "the host architecture for which TCG > > generates code"), if this is really the way TCG uses the term then fine. > > Yes, this is an unfortunate terminology clash, but in a TCG context > 'target' does mean 'host architecture which the backend compiles for' > (see the tcg/README definition in section 2). This is partly because > of TCG's history as a C compiler backend, where 'target' is unambiguous > and may be different from the 'host' architecture the compiler itself > executes on. > > There are several places in tcg/README which use 'target' in the > sense 'QEMU target, ie guest' (as well as lots of uses in the > 'TCG target, ie host' sense), not just this one; it might be a good > idea to put a note in the Definitions section that this document uses > 'guest' when it means what in other areas of QEMU is often referred to > as the 'target', and fix the places where we've accidentally used 'target' > and 'guest would be better. Wei-Ren, can you please convert the other instances in tcg/README where 'target' is used in the 'guest' sense, too? Stefan