From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60318)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1UE0q5-00062a-K9
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 12:12:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1UE0pz-0001wn-Kq
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 12:12:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58194)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1UE0pz-0001wR-AK
	for qemu-devel@nongnu.org; Fri, 08 Mar 2013 12:12:07 -0500
Date: Fri, 8 Mar 2013 14:11:51 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20130308171151.GA29630@amt.cnet>
References: <20121212213631.GA27694@amt.cnet>
 <51384EED.5020709@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51384EED.5020709@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as
	default (v2)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org

On Thu, Mar 07, 2013 at 09:25:17AM +0100, Paolo Bonzini wrote:
> Il 12/12/2012 22:36, Marcelo Tosatti ha scritto:
> > 
> > RTC interrupt reinjection has no known negative effect. Lack of
> > RTC interrupt reinjection, though, has negative effects: time drift
> > for Windows guests which use it as a timer source.
> > 
> > Based on that, enable lost_tick_policy=slew option as default.
> > 
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > 
> > v2: do not change default for older machines types (Paolo Bonzini)
> > 
> > diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> > index c79fca7..c9e007d 100644
> > --- a/hw/mc146818rtc.c
> > +++ b/hw/mc146818rtc.c
> > @@ -884,7 +884,7 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
> >  static Property mc146818rtc_properties[] = {
> >      DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
> >      DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
> > -                               lost_tick_policy, LOST_TICK_DISCARD),
> > +                               lost_tick_policy, LOST_TICK_SLEW),
> >      DEFINE_PROP_END_OF_LIST(),
> >  };
> >  
> > diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> > index 19e342a..475bb4c 100644
> > --- a/hw/pc_piix.c
> > +++ b/hw/pc_piix.c
> > @@ -295,6 +295,10 @@ static QEMUMachine pc_machine_v1_4 = {
> >              .driver   = "usb-tablet",\
> >              .property = "usb_version",\
> >              .value    = stringify(1),\
> > +        },{\
> > +            .driver   = "mc146818rtc",\
> > +            .property = "lost_tick_policy",\
> > +            .value    = "discard",\
> >          }
> >  
> >  static QEMUMachine pc_machine_v1_3 = {
> > 
> > 
> 
> Looks like this was never applied.  Can you redo it for the new 1.5
> machine (compatibility defines are now in hw/pc.h)?
> 
> Paolo

Anthony mentioned that this

http://article.gmane.org/gmane.comp.emulators.qemu/160699

Is the proper way to do it.