From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54135)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1UEi7E-0003ib-SC
	for qemu-devel@nongnu.org; Sun, 10 Mar 2013 11:25:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1UEi6c-00072c-A4
	for qemu-devel@nongnu.org; Sun, 10 Mar 2013 11:24:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56633)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1UEi6b-00070R-Vk
	for qemu-devel@nongnu.org; Sun, 10 Mar 2013 11:24:10 -0400
Date: Sun, 10 Mar 2013 17:24:06 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20130310152406.GK24444@redhat.com>
References: <1362811730-6716-1-git-send-email-pbonzini@redhat.com>
	<1362811730-6716-3-git-send-email-pbonzini@redhat.com>
	<20130310115439.GN11223@redhat.com> <513C9876.6090708@redhat.com>
	<20130310145524.GJ24444@redhat.com> <513CA107.5030602@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <513CA107.5030602@redhat.com>
Subject: Re: [Qemu-devel] [PATCH uq/master 2/2] kvm: forward INIT signals
 coming from the chipset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org

On Sun, Mar 10, 2013 at 04:04:39PM +0100, Paolo Bonzini wrote:
> Il 10/03/2013 15:55, Gleb Natapov ha scritto:
> > > > Why not move INIT case from below as is? Vcpu is reset to correct sate
> > > > by QEMU just like during system_reset.
> > > 
> > > APs would not be able to receive SIPIs after executing do_cpu_init,
> > > because they would stay in KVM_MP_STATE_RUNNABLE state.
> > 
> > If APs are in runnable state after reset with in kernel irq chip we
> > have a bug somewhere.
> 
> Here is where we are resetting the processor.  After clearing
> CPU_INTERRUPT_INIT, no matter what else we do (such as resetting the
> APIC and CPU), we need to set the mp_state to KVM_MP_STATE_INIT_RECEIVED.
> 
> Or if we go with your simpler hypervisor patch, we need to go to either
> KVM_MP_STATE_INIT_RECEIVED for APs (wait for SIPI) or
> KVM_MP_STATE_SIPI_RECEIVED for the BSP (restart running from the reset
> vector).
> 
No need for KVM_MP_STATE_SIPI_RECEIVED. Just make it RUNNING. This is similar to
system_reset path, not? UNINIT for AP, RUNNING for BSP.

> > Should AP be able to get SIPI without INIT after trigger of INIT# line?
> 
> Yes, the effect is the same for an INIT interrupt and the triggering of
> INIT#.
> 
Can you give me SDM pointer?

--
			Gleb.