From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEiuh-00041Y-8L for qemu-devel@nongnu.org; Sun, 10 Mar 2013 12:15:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEiue-0007Xl-8N for qemu-devel@nongnu.org; Sun, 10 Mar 2013 12:15:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEiud-0007X7-TN for qemu-devel@nongnu.org; Sun, 10 Mar 2013 12:15:52 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2AGFp5n008009 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 10 Mar 2013 12:15:51 -0400 Date: Sun, 10 Mar 2013 18:16:13 +0200 From: "Michael S. Tsirkin" Message-ID: <20130310161613.GA13315@redhat.com> References: <20130307230844.31144.93342.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130307230844.31144.93342.stgit@bling.home> Subject: Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate function in pci_bridge_dev. Tested with an > assigned device behind a PCIe switch behind a PCIe root port at > addresses 0-3. Note that Linux requires the pci=pcie_scan_all boot > option to find devices behind PCIe ports if not addr=0.0. Windows > finds them but won't use them (code 10). I'm guessing this only applies to downstream ports right? The spec IIRC says that slot is ignored. The real way is probably by making a device an endpoint integrated into the switch, so it's behind the upstream port. > This replaces the ioh3420 & xio3130 upstream/downstream patches. > Thanks, > > Alex > > --- > > Alex Williamson (2): > pci_bridge: Use a default map_irq function > pci_bridge: Remove duplicate IRQ swizzle function > > > hw/pci/pci_bridge.c | 2 +- > hw/pci_bridge_dev.c | 9 --------- > 2 files changed, 1 insertion(+), 10 deletions(-)