From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEivx-0004po-7f for qemu-devel@nongnu.org; Sun, 10 Mar 2013 12:17:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEivu-0007sZ-0g for qemu-devel@nongnu.org; Sun, 10 Mar 2013 12:17:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEivt-0007sN-Pd for qemu-devel@nongnu.org; Sun, 10 Mar 2013 12:17:09 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2AGH9DE002998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 10 Mar 2013 12:17:09 -0400 Date: Sun, 10 Mar 2013 18:17:32 +0200 From: "Michael S. Tsirkin" Message-ID: <20130310161732.GA13539@redhat.com> References: <20130307230844.31144.93342.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130307230844.31144.93342.stgit@bling.home> Subject: Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate function in pci_bridge_dev. Tested with an > assigned device behind a PCIe switch behind a PCIe root port at > addresses 0-3. Note that Linux requires the pci=pcie_scan_all boot > option to find devices behind PCIe ports if not addr=0.0. Windows > finds them but won't use them (code 10). > > This replaces the ioh3420 & xio3130 upstream/downstream patches. > Thanks, > > Alex Applied, thanks. > --- > > Alex Williamson (2): > pci_bridge: Use a default map_irq function > pci_bridge: Remove duplicate IRQ swizzle function > > > hw/pci/pci_bridge.c | 2 +- > hw/pci_bridge_dev.c | 9 --------- > 2 files changed, 1 insertion(+), 10 deletions(-)