qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] MinGW: Replace setsockopt by qemu_setsocketopt
Date: Mon, 11 Mar 2013 10:37:11 +0100	[thread overview]
Message-ID: <20130311093711.GA2543@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1362769112-6097-1-git-send-email-sw@weilnetz.de>

On Fri, Mar 08, 2013 at 07:58:32PM +0100, Stefan Weil wrote:
> Instead of adding missing type casts which are needed by MinGW for the
> 4th argument, the patch uses qemu_setsockopt which was invented for this
> purpose.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> I did not fix some coding style issues in modified slirp code
> (tabs, line length). Nor did I replace setsockopt in code which
> is unused for MinGW (linux-user, tests).
> 
> - Stefan W.
> 
> 
>  bt-host.c           |    2 +-
>  gdbstub.c           |    2 +-
>  net/socket.c        |   21 ++++++++++-----------
>  slirp/misc.c        |    4 ++--
>  slirp/socket.c      |    4 ++--
>  slirp/tcp_subr.c    |    8 ++++----
>  slirp/udp.c         |    2 +-
>  util/osdep.c        |    4 ++--
>  util/qemu-sockets.c |   10 +++++-----
>  9 files changed, 28 insertions(+), 29 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

      reply	other threads:[~2013-03-11  9:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 18:58 [Qemu-devel] [PATCH] MinGW: Replace setsockopt by qemu_setsocketopt Stefan Weil
2013-03-11  9:37 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130311093711.GA2543@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).