From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF3Qq-0001QD-4V for qemu-devel@nongnu.org; Mon, 11 Mar 2013 10:10:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF3Qm-0006IE-KE for qemu-devel@nongnu.org; Mon, 11 Mar 2013 10:10:28 -0400 Date: Mon, 11 Mar 2013 15:10:21 +0100 From: Stefan Hajnoczi Message-ID: <20130311141021.GA6519@stefanha-thinkpad.redhat.com> References: <1362589321-21402-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362589321-21402-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qcow2: make is_allocated return true for zero clusters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org On Wed, Mar 06, 2013 at 06:02:01PM +0100, Paolo Bonzini wrote: > Otherwise, live migration of the top layer will miss zero clusters and > let the backing file show through. This also matches what is done in qed. > > QCOW2_CLUSTER_ZERO clusters are invalid in v2 image files. Check this > directly in qcow2_get_cluster_offset instead of replicating the test > everywhere. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Paolo Bonzini > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan