From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF3sk-00080A-F5 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 10:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF3sb-00046O-FK for qemu-devel@nongnu.org; Mon, 11 Mar 2013 10:39:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF3sb-000462-5f for qemu-devel@nongnu.org; Mon, 11 Mar 2013 10:39:09 -0400 Date: Mon, 11 Mar 2013 15:39:05 +0100 From: Stefan Hajnoczi Message-ID: <20130311143905.GB7611@stefanha-thinkpad.redhat.com> References: <1362992462-1864-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362992462-1864-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> Subject: Re: [Qemu-devel] [PATCH] sheepdog: set io_flush handler in do_co_req List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MORITA Kazutaka Cc: kwolf@redhat.com, qemu-devel@nongnu.org On Mon, Mar 11, 2013 at 06:01:02PM +0900, MORITA Kazutaka wrote: > If an io_flush handler is not set, qemu_aio_wait doesn't invoke > callbacks. > > Signed-off-by: MORITA Kazutaka > --- > block/sheepdog.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index e4ec32d..cb0eeed 100644 > --- a/block/sheepdog.c > +++ b/block/sheepdog.c > @@ -501,6 +501,13 @@ static void restart_co_req(void *opaque) > qemu_coroutine_enter(co, NULL); > } > > +static int have_co_req(void *opaque) > +{ > + /* this handler is set only when there is a pending request, so > + * always returns 1. */ > + return 1; > +} > + > typedef struct SheepdogReqCo { > int sockfd; > SheepdogReq *hdr; > @@ -523,14 +530,14 @@ static coroutine_fn void do_co_req(void *opaque) > unsigned int *rlen = srco->rlen; > > co = qemu_coroutine_self(); > - qemu_aio_set_fd_handler(sockfd, NULL, restart_co_req, NULL, co); > + qemu_aio_set_fd_handler(sockfd, NULL, restart_co_req, have_co_req, co); > > ret = send_co_req(sockfd, hdr, data, wlen); Which tree is this patch against? block/sheepdog.c:do_co_req() has a socket_set_block(sockfd) call before this line. Is there a guarantee that only one coroutine executes do_co_req() at a time? Otherwise the first coroutine that finishes the function sets io_flush to NULL even though there's still another request processing. Stefan