From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1UF4VO-0002dD-3j
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 11:19:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1UF4VK-0005lI-0o
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 11:19:14 -0400
Received: from nodalink.pck.nerim.net ([62.212.105.220]:57283
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1UF4VJ-0005kq-PR
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 11:19:09 -0400
Date: Mon, 11 Mar 2013 16:20:03 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130311152003.GC3824@irqsave.net>
References: <1360153926-9492-1-git-send-email-benoit@irqsave.net>
	<1360153926-9492-20-git-send-email-benoit@irqsave.net>
	<20130207101621.GM1081@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20130207101621.GM1081@stefanha-thinkpad.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and
 image creation code.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

> > +    if (dedup) {
> > +        version =3D 3;
> > +    }
>=20
> Lazy refcounts don't force the version.  It would be consistent to
> refrain from forcing the version too.

I don't understand. Aren't the incompatible features bits implying versio=
n =3D 3 ?
When compat=3D1.1 is set the code force version to 3.

Beno=EEt