From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF8VP-0003LW-Bo for qemu-devel@nongnu.org; Mon, 11 Mar 2013 15:35:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF8VL-0005uk-2u for qemu-devel@nongnu.org; Mon, 11 Mar 2013 15:35:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF8VK-0005uU-RZ for qemu-devel@nongnu.org; Mon, 11 Mar 2013 15:35:27 -0400 Date: Mon, 11 Mar 2013 21:35:45 +0200 From: "Michael S. Tsirkin" Message-ID: <20130311193545.GA31531@redhat.com> References: <20130307184647.GA31012@redhat.com> <87d2vbx9rz.fsf@blackfin.pond.sub.org> <20130307202309.GA13088@redhat.com> <87a9qel3v0.fsf@blackfin.pond.sub.org> <87vc92dndv.fsf@codemonkey.ws> <20130311173929.GA29465@redhat.com> <87620xrb3x.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87620xrb3x.fsf@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Eduardo Habkost , libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Markus Armbruster , Gerd Hoffmann , Paolo Bonzini , Luiz Capitulino , Andreas =?iso-8859-1?Q?F=E4rber?= On Mon, Mar 11, 2013 at 02:26:58PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Mar 08, 2013 at 07:36:28AM -0600, Anthony Liguori wrote: > >> Markus Armbruster writes: > >> > >> > "Michael S. Tsirkin" writes: > >> > > >> >> On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > >> >>> "Michael S. Tsirkin" writes: > >> >>> > >> >>> > libvirt has a long-standing bug: when removing the device, > >> >>> > it can request removal but does not know when the > >> >>> > removal completes. Add an event so we can fix this in a robust way. > >> >>> > > >> >>> > Signed-off-by: Michael S. Tsirkin > >> >>> > >> >>> Speaking as the acting QMP maintainer, just to avoid misunderstandings: > >> >>> there's disagreement on the event's design, namely when it should fire, > >> >>> and how it should name the device. I don't want the discussion > >> >>> preempted by a commit. > >> >> > >> >> Yes, you are asking for more functionality, but can I add this in a > >> >> follow-up commit please? I prefer this patch as is, as it can be > >> >> backported to stable branches and downstreams. Upstream a follow up > >> >> patch can add fields and more triggers which won't apply to any > >> >> downstreams. > >> > > >> > If you want to address my review comments in a separate patch, go right > >> > ahead. Please post both together as a series, for coherent review and > >> > to simplify patch tracking. > >> > > >> > I'm asking for two things: > >> > > >> > 1. Event member path. Fair to call this "more functionality". I agree > >> > that backporting it to pre-QOM versions isn't practical. > >> > > >> > 2. Sane event trigger condition: on any device deletion, not just when > >> > the device happens to have a qdev ID. This isn't "more", it's > >> > "different". > >> > >> Ack. > >> > >> Regards, > >> > >> Anthony Liguori > > > > > > So how does one get the path that you require? > > > > ERROR:qom/object.c:1011:object_get_canonical_path: assertion failed: > > (prop != NULL) > > Can you share your patch? This means something is wrong. All devices > have a canonical path. > > Regards, > > Anthony Liguori I figured it out - we were trying to get the path after the device was detached from the parent. We'll just have to calculate the path before unparenting and pass it in. -- MST