From: Stefan Hajnoczi <stefanha@gmail.com>
To: Asias He <asias@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, Nicholas Bellinger <nab@linux-iscsi.org>,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 WIP 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module
Date: Tue, 12 Mar 2013 09:20:24 +0100 [thread overview]
Message-ID: <20130312082024.GA18112@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1363069782-10735-3-git-send-email-asias@redhat.com>
On Tue, Mar 12, 2013 at 02:29:42PM +0800, Asias He wrote:
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index 39c1966..4a97ca1 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
These changes break the build for non-Linux hosts. Please introduce a
CONFIG_VHOST_SCSI and #ifdef appropriate sections in hw/virtio-pci.c.
CONFIG_VIRTFS does the same thing.
> +static Property vhost_scsi_properties[] = {
> + DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
This flag makes QEMU's virtqueue handling use ioeventfd. Since the
vhost-scsi.c takes over the guest/host notifiers, we never do QEMU
virtqueue processing and the "ioeventfd" flag has no real meaning. You
can drop it.
next prev parent reply other threads:[~2013-03-12 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 6:29 [Qemu-devel] [PATCH V2 WIP 0/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module Asias He
2013-03-12 6:29 ` [Qemu-devel] [PATCH V2 WIP 1/2] virtio-scsi: create VirtIOSCSICommon Asias He
2013-03-12 6:29 ` [Qemu-devel] [PATCH V2 WIP 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module Asias He
2013-03-12 8:20 ` Stefan Hajnoczi [this message]
2013-03-13 2:49 ` Asias He
2013-03-14 4:25 ` [Qemu-devel] [PATCH V2 WIP 0/2] " Asias He
2013-03-14 9:25 ` Asias He
2013-03-14 9:46 ` Michael S. Tsirkin
2013-03-14 10:00 ` Paolo Bonzini
2013-03-14 10:21 ` Michael S. Tsirkin
2013-03-15 0:58 ` Asias He
2013-03-15 0:55 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312082024.GA18112@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=asias@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).