From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51340)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UFKRi-0004kO-PO
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:20:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UFKRh-0005PG-3q
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:20:30 -0400
Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:40341)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UFKRg-0005O5-U8
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:20:29 -0400
Received: by mail-we0-f171.google.com with SMTP id u54so4517695wey.30
	for <qemu-devel@nongnu.org>; Tue, 12 Mar 2013 01:20:28 -0700 (PDT)
Date: Tue, 12 Mar 2013 09:20:24 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130312082024.GA18112@stefanha-thinkpad.redhat.com>
References: <1363069782-10735-1-git-send-email-asias@redhat.com>
	<1363069782-10735-3-git-send-email-asias@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363069782-10735-3-git-send-email-asias@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 WIP 2/2] vhost-scsi: new device
 supporting the tcm_vhost Linux kernel module
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Asias He <asias@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Nicholas Bellinger <nab@linux-iscsi.org>, virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, Mar 12, 2013 at 02:29:42PM +0800, Asias He wrote:
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index 39c1966..4a97ca1 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c

These changes break the build for non-Linux hosts.  Please introduce a
CONFIG_VHOST_SCSI and #ifdef appropriate sections in hw/virtio-pci.c.

CONFIG_VIRTFS does the same thing.

> +static Property vhost_scsi_properties[] = {
> +    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),

This flag makes QEMU's virtqueue handling use ioeventfd.  Since the
vhost-scsi.c takes over the guest/host notifiers, we never do QEMU
virtqueue processing and the "ioeventfd" flag has no real meaning.  You
can drop it.