From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFS6m-0004Kt-8W for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:31:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFS6g-0001tB-3K for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:31:23 -0400 Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:45462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFS6f-0001rZ-RG for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:31:18 -0400 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 Mar 2013 16:28:30 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id EDDAA17D802D for ; Tue, 12 Mar 2013 16:31:46 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2CGUwm433947694 for ; Tue, 12 Mar 2013 16:30:58 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2CGV71m012790 for ; Tue, 12 Mar 2013 10:31:07 -0600 Date: Tue, 12 Mar 2013 17:31:02 +0100 From: Cornelia Huck Message-ID: <20130312173102.3e86ef76@gondolin> In-Reply-To: <513F482E.1000106@greensocs.com> References: <1363080131-16427-1-git-send-email-fred.konrad@greensocs.com> <1363080131-16427-3-git-send-email-fred.konrad@greensocs.com> <513F3DAF.8050405@greensocs.com> <513F44E7.2020306@greensocs.com> <513F482E.1000106@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: KONRAD =?UTF-8?B?RnLDqWTDqXJpYw==?= Cc: Kevin Wolf , Peter Maydell , aliguori@us.ibm.com, mst@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, Stefan Hajnoczi , afaerber@suse.de On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Fr=C3=A9d=C3=A9ric wrote: > On 12/03/2013 16:12, Peter Maydell wrote: > > On 12 March 2013 15:08, KONRAD Fr=C3=A9d=C3=A9ric wrote: > >> On 12/03/2013 15:42, Peter Maydell wrote: > >>> Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_PROPERTY > >>> and DEFINE_DATA_PLANE_PROPERTIES are just convenience macros, not > >>> ones that are expected to be used by other code, right? So you can > >>> define them with commas (and name them something so it's obvious > >>> they're not intended for wider use as property array elements), > >>> and then just make sure your public-facing DEFINE_VIRTIO_BLK_PROPERTI= ES > >>> doesn't end with a comma. (You can do that by putting the macros > >>> that expand to maybe-comma-or-not at the front, not the end.) > >>> > >>> -- PMM > >> ok, I can put a comment which say not to use them? > > And suitable macro names (ie not ones which look like all > > the other DEFINE_FOO_PROPERTIES ones). Alternatively since the > > macro's only used once as far as I can see, you could just not > > bother to abstract it out. The virtio-ccw blk properties still > > just have inline #ifdefs for the scsi prop for instance. > > > > -- PMM >=20 > The macro is used for virtio-blk device and virtio-blk-pci. > s390x devices don't use the same properties. >=20 Looking at the s390 devices, the difference seems to be the following: - CHS - missing on virtio-ccw, I'll do a patch. - config_wce - missing on s390-virtio and virtio-ccw, should probably be added. - x-data-plane - we plan to add this eventually to virtio-ccw, but not to s390-virtio. Could that be split out from the generic properties?