From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFbl3-0000Rm-0b for qemu-devel@nongnu.org; Tue, 12 Mar 2013 22:49:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFbky-0004vK-JW for qemu-devel@nongnu.org; Tue, 12 Mar 2013 22:49:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFbky-0004vG-Bn for qemu-devel@nongnu.org; Tue, 12 Mar 2013 22:49:32 -0400 Date: Wed, 13 Mar 2013 10:49:18 +0800 From: Asias He Message-ID: <20130313024918.GA15369@hj.localdomain> References: <1363069782-10735-1-git-send-email-asias@redhat.com> <1363069782-10735-3-git-send-email-asias@redhat.com> <20130312082024.GA18112@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130312082024.GA18112@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH V2 WIP 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Rusty Russell , qemu-devel@nongnu.org, Nicholas Bellinger , virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Stefan Hajnoczi , Paolo Bonzini On Tue, Mar 12, 2013 at 09:20:24AM +0100, Stefan Hajnoczi wrote: > On Tue, Mar 12, 2013 at 02:29:42PM +0800, Asias He wrote: > > diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c > > index 39c1966..4a97ca1 100644 > > --- a/hw/virtio-pci.c > > +++ b/hw/virtio-pci.c > > These changes break the build for non-Linux hosts. Please introduce a > CONFIG_VHOST_SCSI and #ifdef appropriate sections in hw/virtio-pci.c. > > CONFIG_VIRTFS does the same thing. okay. > > +static Property vhost_scsi_properties[] = { > > + DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true), > > This flag makes QEMU's virtqueue handling use ioeventfd. Since the > vhost-scsi.c takes over the guest/host notifiers, we never do QEMU > virtqueue processing and the "ioeventfd" flag has no real meaning. You > can drop it. okay. Thanks, Stefan! -- Asias