From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFshr-0006nj-7L for qemu-devel@nongnu.org; Wed, 13 Mar 2013 16:55:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFshq-0006G9-0z for qemu-devel@nongnu.org; Wed, 13 Mar 2013 16:55:27 -0400 Received: from mail-ye0-f182.google.com ([209.85.213.182]:61927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFshp-0006G5-Si for qemu-devel@nongnu.org; Wed, 13 Mar 2013 16:55:25 -0400 Received: by mail-ye0-f182.google.com with SMTP id r9so260560yen.13 for ; Wed, 13 Mar 2013 13:55:25 -0700 (PDT) Sender: fluxion Date: Wed, 13 Mar 2013 15:52:00 -0500 From: mdroth Message-ID: <20130313205200.GA6188@vm> References: <1363200988-17865-1-git-send-email-jschopp@linux.vnet.ibm.com> <1363200988-17865-6-git-send-email-jschopp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363200988-17865-6-git-send-email-jschopp@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Schopp Cc: Michael Tsirkin , qemu-devel@nongnu.org, Stefan Berger On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: > Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new interfaces if possible, since it adds to feature disparities between visitor implementations. > > Cc: Michael Tsirkin > Signed-off-by: Stefan Berger > Signed-off-by: Joel Schopp > --- > include/qapi/visitor-impl.h | 2 ++ > include/qapi/visitor.h | 2 ++ > qapi/qapi-visit-core.c | 8 ++++++++ > 3 files changed, 12 insertions(+) > > diff --git a/include/qapi/visitor-impl.h b/include/qapi/visitor-impl.h > index 9d87f2d..dc0e25c 100644 > --- a/include/qapi/visitor-impl.h > +++ b/include/qapi/visitor-impl.h > @@ -38,6 +38,8 @@ struct Visitor > size_t elem_count, size_t elem_size, Error **errp); > void (*next_carray)(Visitor *v, Error **errp); > void (*end_carray)(Visitor *v, Error **errp); > + void (*type_sized_buffer)(Visitor *v, uint8_t **obj, size_t size, > + const char *name, Error **errp); > > /* May be NULL */ > void (*start_optional)(Visitor *v, bool *present, const char *name, > diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h > index 74bddef..7c7bb98 100644 > --- a/include/qapi/visitor.h > +++ b/include/qapi/visitor.h > @@ -55,5 +55,7 @@ void visit_start_carray(Visitor *v, void **obj, const char *name, > size_t elem_count, size_t elem_size, Error **errp); > void visit_next_carray(Visitor *v, Error **errp); > void visit_end_carray(Visitor *v, Error **errp); > +void visit_type_sized_buffer(Visitor *v, uint8_t **obj, size_t len, > + const char *name, Error **errp); > > #endif > diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c > index d9982f8..4b36a54 100644 > --- a/qapi/qapi-visit-core.c > +++ b/qapi/qapi-visit-core.c > @@ -338,3 +338,11 @@ void visit_end_carray(Visitor *v, Error **errp) > v->end_carray(v, errp); > } > } > + > +void visit_type_sized_buffer(Visitor *v, uint8_t **obj, size_t len, > + const char *name, Error **errp) > +{ > + if (!error_is_set(errp)) { > + v->type_sized_buffer(v, obj, len, name, errp); > + } > +} > -- > 1.7.10.4 > >