From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UG4Xb-0007wM-Nm
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 05:33:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UG4XS-0005EZ-CF
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 05:33:39 -0400
Received: from [222.73.24.84] (port=59404 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UG4XR-0005Dx-Vk
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 05:33:30 -0400
Date: Thu, 14 Mar 2013 17:33:19 +0800
From: Hu Tao <hutao@cn.fujitsu.com>
Message-ID: <20130314093319.GD20796@localhost.localdomain>
References: <1363250927-20298-1-git-send-email-hutao@cn.fujitsu.com>
	<20130314085718.GZ11223@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20130314085718.GZ11223@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Subject: Re: [Qemu-devel] [PATCH] Add pvevent device driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Orit Wasserman <owasserm@redhat.com>, Juan Quintela <quintela@redhat.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Andrew Jones <drjones@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Sasha Levin <levinsasha928@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, Mar 14, 2013 at 10:57:18AM +0200, Gleb Natapov wrote:
> On Thu, Mar 14, 2013 at 04:48:47PM +0800, Hu Tao wrote:
> > pvevent device is used to notify host(qemu) when guest panic
> > happens.
> > 
> > ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg02293.html
> > 
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > ---
> >  src/acpi-dsdt-isa.dsl | 30 ++++++++++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> > 
> > diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl
> > index 23761db..d083245 100644
> > --- a/src/acpi-dsdt-isa.dsl
> > +++ b/src/acpi-dsdt-isa.dsl
> > @@ -99,4 +99,34 @@ Scope(\_SB.PCI0.ISA) {
> >              IRQNoFlags() { 3 }
> >          })
> >      }
> > +
> > +    Device(PEVT) {
> > +        Name(_HID, "MSFT0001")
> We cannot use MSFT!

OK, I see now, we have to use QEMU0001 or like. More question: if I
request ACPI ID: QEMU  from pnpid@microsoft.com, who should be CCed,
Anthony, qemu-list or any others?


> 
> > +        OperationRegion(PEOR, SystemIO, 0x0505, 0x01)
> IO port should be received form QEMU by fw_cfg and patched here at run time.

If I'm right, io port can be passed to seabios through fw_cfg file
interface, but I'm still figuring out how to patch DSDT here and below at
run time.  Maybe build_ssdt() is close to this.

> 
> > +        Field(PEOR, ByteAcc, NoLock, Preserve) {
> > +            PEPT,   8,
> > +        }
> > +
> > +        Method(_STA, 0, NotSerialized) {
> > +            Store(PEPT, Local0)
> > +            If (LEqual(Local0, Zero)) {
> > +                Return (0x00)
> > +            } Else {
> > +                Return (0x0F)
> > +            }
> > +        }
> No probing. If QEMU does not provide IO port function should be patched
> to return zero.
> 
> > +
> > +        Method(RDPT, 0, NotSerialized) {
> > +            Store(PEPT, Local0)
> > +            Return (Local0)
> > +        }
> > +
> > +        Method(WRPT, 1, NotSerialized) {
> > +            Store(Arg0, PEPT)
> > +        }
> > +
> > +        Name(_CRS, ResourceTemplate() {
> > +            IO(Decode16, 0x0505, 0x0505, 0x01, 0x01)
> > +        })
> > +    }
> >  }
> > -- 
> > 1.8.1.4
> 
> --
> 			Gleb.