From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG3kW-0000Oa-SL for qemu-devel@nongnu.org; Thu, 14 Mar 2013 04:42:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UG3kU-0002xF-Pa for qemu-devel@nongnu.org; Thu, 14 Mar 2013 04:42:56 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:38901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG3kU-0002wg-Hb for qemu-devel@nongnu.org; Thu, 14 Mar 2013 04:42:54 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 14 Mar 2013 08:41:40 -0000 Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2E8gfJ748758874 for ; Thu, 14 Mar 2013 08:42:41 GMT Received: from d06av11.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2E8gnSR004373 for ; Thu, 14 Mar 2013 02:42:50 -0600 Date: Thu, 14 Mar 2013 09:42:48 +0100 From: Cornelia Huck Message-ID: <20130314094248.4d76975f@gondolin> In-Reply-To: <51418C62.3080800@greensocs.com> References: <1363080131-16427-1-git-send-email-fred.konrad@greensocs.com> <1363080131-16427-3-git-send-email-fred.konrad@greensocs.com> <513F3DAF.8050405@greensocs.com> <513F44E7.2020306@greensocs.com> <513F482E.1000106@greensocs.com> <20130312173102.3e86ef76@gondolin> <514037CA.1010607@greensocs.com> <51409C0F.4000007@greensocs.com> <20130314082535.64c08ea5@gondolin> <51418C62.3080800@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: KONRAD =?UTF-8?B?RnLDqWTDqXJpYw==?= Cc: Kevin Wolf , Peter Maydell , aliguori@us.ibm.com, mst@redhat.com, mark.burton@greensocs.com, Alexander Graf , qemu-devel@nongnu.org, Stefan Hajnoczi , afaerber@suse.de On Thu, 14 Mar 2013 09:37:54 +0100 KONRAD Fr=C3=A9d=C3=A9ric wrote: > On 14/03/2013 08:25, Cornelia Huck wrote: > > On Wed, 13 Mar 2013 16:32:31 +0100 > > KONRAD Fr=C3=A9d=C3=A9ric wrote: > > > >> On 13/03/2013 09:24, KONRAD Fr=C3=A9d=C3=A9ric wrote: > >>> On 12/03/2013 17:31, Cornelia Huck wrote: > >>>> On Tue, 12 Mar 2013 16:22:22 +0100 > >>>> KONRAD Fr=C3=A9d=C3=A9ric wrote: > >>>> > >>>>> On 12/03/2013 16:12, Peter Maydell wrote: > >>>>>> On 12 March 2013 15:08, KONRAD Fr=C3=A9d=C3=A9ric > >>>>>> wrote: > >>>>>>> On 12/03/2013 15:42, Peter Maydell wrote: > >>>>>>>> Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_PROPER= TY > >>>>>>>> and DEFINE_DATA_PLANE_PROPERTIES are just convenience macros, not > >>>>>>>> ones that are expected to be used by other code, right? So you c= an > >>>>>>>> define them with commas (and name them something so it's obvious > >>>>>>>> they're not intended for wider use as property array elements), > >>>>>>>> and then just make sure your public-facing > >>>>>>>> DEFINE_VIRTIO_BLK_PROPERTIES > >>>>>>>> doesn't end with a comma. (You can do that by putting the macros > >>>>>>>> that expand to maybe-comma-or-not at the front, not the end.) > >>>>>>>> > >>>>>>>> -- PMM > >>>>>>> ok, I can put a comment which say not to use them? > >>>>>> And suitable macro names (ie not ones which look like all > >>>>>> the other DEFINE_FOO_PROPERTIES ones). Alternatively since the > >>>>>> macro's only used once as far as I can see, you could just not > >>>>>> bother to abstract it out. The virtio-ccw blk properties still > >>>>>> just have inline #ifdefs for the scsi prop for instance. > >>>>>> > >>>>>> -- PMM > >>>>> The macro is used for virtio-blk device and virtio-blk-pci. > >>>>> s390x devices don't use the same properties. > >>>>> > >>>> Looking at the s390 devices, the difference seems to be the followin= g: > >>>> > >>>> - CHS - missing on virtio-ccw, I'll do a patch. > >>>> - config_wce - missing on s390-virtio and virtio-ccw, should probably > >>>> be added. > >>>> - x-data-plane - we plan to add this eventually to virtio-ccw, but n= ot > >>>> to s390-virtio. Could that be split out from the generic propert= ies? > >>>> > >>> ok, so what I can do is: > >>> > >>> - split up x-data-plane property (so it will be only in virtio-pci.c). > >>> - fix this comma thing. > >>> > >>> Then when you put these two missing properties you can just replace > >>> all of them > >>> with the macro. > >>> > >>> Is that ok for everybody? Peter? Stefan? > >>> > >> Any other suggestion? > > I currently have the following two patches sitting in my pending queue > > (git://github.com/cohuck/qemu virtio-ccw-pending); I'll probably submit > > them once my current pull request is through. > > > > On top of this, s390-virtio and virtio-ccw could use the generic macro > > for the virtio-blk properties from the start if x-data-plane is split > > out (I can add it to virtio-ccw once we support it). > > > Ok good, >=20 > And what about config-wce property for virtio-blk-s390x? It is missing to= o. See the second patch :)