From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG4uk-0008Ih-2Z for qemu-devel@nongnu.org; Thu, 14 Mar 2013 05:57:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UG4uf-0004bI-At for qemu-devel@nongnu.org; Thu, 14 Mar 2013 05:57:34 -0400 Received: from mail-bk0-x236.google.com ([2a00:1450:4008:c01::236]:32778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG4uf-0004bE-3z for qemu-devel@nongnu.org; Thu, 14 Mar 2013 05:57:29 -0400 Received: by mail-bk0-f54.google.com with SMTP id w5so921719bku.27 for ; Thu, 14 Mar 2013 02:57:28 -0700 (PDT) Date: Thu, 14 Mar 2013 10:57:25 +0100 From: Stefan Hajnoczi Message-ID: <20130314095725.GA12564@stefanha-thinkpad.redhat.com> References: <1363184055-8610-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363184055-8610-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] dataplane: fix hang introduced by AioContext transition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Wed, Mar 13, 2013 at 03:14:15PM +0100, Paolo Bonzini wrote: > The bug is that the EventNotifiers do have a NULL io_flush callback. > Because _none_ of the callbacks on the dataplane AioContext have such a > callback, aio_poll will simply do nothing. Fixed by adding the callbacks: > the ioeventfd will always be polled (this can change in the future to > pause/resume the processing during live snapshots or similar operations); > the ioqueue will be polled if there are outstanding requests. > > I must admit I have screwed up my testing somehow, because commit > 2c20e71 does not work even if cherry-picked on top of 1.4.0, and this > patch fixes it there as well. > > Signed-off-by: Paolo Bonzini > --- > hw/dataplane/virtio-blk.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Thanks, tested and applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan