From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UG7Ay-0007EX-8g
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:22:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UG7Ao-0002Hx-4e
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:22:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44936)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UG7An-0002Hn-SM
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:22:18 -0400
Date: Thu, 14 Mar 2013 14:22:37 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130314122237.GA18850@redhat.com>
References: <cover.1363196545.git.mst@redhat.com>
	<60194bbd0a9d9259beb9a14e19c1706bd9a07e97.1363196545.git.mst@redhat.com>
	<878v5q2yo8.fsf@blackfin.pond.sub.org>
	<20130314084817.GA14977@redhat.com>
	<87fvzyw54t.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87fvzyw54t.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Eduardo Habkost <ehabkost@redhat.com>, libvir-list@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Thu, Mar 14, 2013 at 01:13:54PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote:
> >> "Michael S. Tsirkin" <mst@redhat.com> writes:
> [...]
> >> > diff --git a/qapi-schema.json b/qapi-schema.json
> >> > index 28b070f..bb361e1 100644
> >> > --- a/qapi-schema.json
> >> > +++ b/qapi-schema.json
> >> > @@ -2354,7 +2354,9 @@
> >> >  # Notes: When this command completes, the device may not be removed from the
> >> >  #        guest.  Hot removal is an operation that requires guest cooperation.
> >> >  #        This command merely requests that the guest begin the hot removal
> >> > -#        process.
> >> > +#        process.  Completion of the device removal process is signaled with a
> >> > +#        DEVICE_DELETED event. Guest reset will automatically complete removal
> >> > +#        for all devices.
> >> >  #
> >> >  # Since: 0.14.0
> >> >  ##
> >> 
> >> What do you mean by "Guest reset will automatically complete removal for
> >> all devices"?
> >
> > Just this. Try this: rmmod acpiphp in guest, then:
> >
> > device_del
> > system_reset
> >
> > and see the device disappear even though it was not acked by guest.
> 
> Cool, I didn't know that.
> 
> Just to make sure: does this automatic removal completion send
> DEVICE_DELETED events?

With my patch, it does.