From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGFsz-00029o-4U
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:40:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGFsx-00043Y-UB
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:40:29 -0400
Received: from mail-gg0-x22d.google.com ([2607:f8b0:4002:c02::22d]:61407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGFsx-00043U-P4
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:40:27 -0400
Received: by mail-gg0-f173.google.com with SMTP id b6so471390ggm.32
	for <qemu-devel@nongnu.org>; Thu, 14 Mar 2013 14:40:27 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Thu, 14 Mar 2013 16:36:59 -0500
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20130314213659.GC9093@vm>
References: <1363273553-29111-1-git-send-email-lilei@linux.vnet.ibm.com>
	<1363273553-29111-2-git-send-email-lilei@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363273553-29111-2-git-send-email-lilei@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for
	guest-get-time
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, Mar 14, 2013 at 11:05:52PM +0800, Lei Li wrote:
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  qga/commands-win32.c | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 7e8ecb3..b395bd5 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -22,6 +22,12 @@
>  #define SHTDN_REASON_FLAG_PLANNED 0x80000000
>  #endif
> 
> +/* multiple of 100 nanoseconds elapsed between windows baseline
> +   (1/1/1601) and Unix Epoch (1/1/1970), accounting for leap years */
> +#define W32_FT_OFFSET (10000000ULL * 60 * 60 * 24 * \
> +                       (365 * (1970 - 1601) +       \
> +                        (1970 - 1601) / 4 - 3))
> +
>  static void acquire_privilege(const char *name, Error **err)
>  {
>      HANDLE token;
> @@ -108,6 +114,29 @@ void qmp_guest_shutdown(bool has_mode, const char *mode, Error **err)
>      }
>  }
> 
> +int64_t qmp_guest_get_time(Error **errp)
> +{
> +    SYSTEMTIME ts = {0};
> +    int64_t time_ns;
> +    FILETIME tf;
> +
> +    GetSystemTime(&ts);
> +    if (ts.wYear < 1601 || ts.wYear > 30827) {
> +        error_setg(errp, "Failed to get time");
> +        return -1;
> +    }
> +
> +    if (!SystemTimeToFileTime(&ts, &tf)) {
> +        error_setg_errno(errp, errno, "Failed to convert system time");

I missed this is well, SystemTimeToFileTime() doesn't set errno, but if
this is the only change needed I can fix this up in my tree.

> +        return -1;
> +    }
> +
> +    time_ns = ((((int64_t)tf.dwHighDateTime << 32) | tf.dwLowDateTime)
> +                - W32_FT_OFFSET) * 100;
> +
> +    return time_ns;
> +}
> +
>  int64_t qmp_guest_file_open(const char *path, bool has_mode, const char *mode, Error **err)
>  {
>      error_set(err, QERR_UNSUPPORTED);
> -- 
> 1.7.11.7
>