From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGFxq-0004I8-Kj
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:45:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGFxn-0005PS-EW
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:45:30 -0400
Received: from mail-yh0-x22a.google.com ([2607:f8b0:4002:c01::22a]:33681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGFxn-0005PO-BH
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:45:27 -0400
Received: by mail-yh0-f42.google.com with SMTP id w49so488407yhw.15
	for <qemu-devel@nongnu.org>; Thu, 14 Mar 2013 14:45:26 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Thu, 14 Mar 2013 16:41:25 -0500
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20130314214125.GD9093@vm>
References: <1363273553-29111-1-git-send-email-lilei@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363273553-29111-1-git-send-email-lilei@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/2 v6] Add Windows support for time resync
	by qemu-ga
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, Mar 14, 2013 at 11:05:51PM +0800, Lei Li wrote:
> This patch series attempts to add Windows implementation
> for qemu-ga commands guest-get-time and guest-set-time.
> 
> The previous thread about the interfaces introduced and 
> the POSIX-specific command implementation has already
> been accepted, the reference link:
> 
> http://article.gmane.org/gmane.comp.emulators.qemu/198472
> 
> Notes:
> Now It was tested on Windows XP SP3 and Windows 7.
> Please comment!

Series looks good other than comment in patch 1. I can fix this in tree
or you can send another version.

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> 
> Thanks.
> 
> Changes since v5:
>   - Fix the error check for GetSystemTime() from Michael.
>   - Other fixups from Michael.
> 
> Changes since v4:
>   - Error handel improvement from Michael.
>   - Do the math explicitly for the time convert of FILETIME
>     suggested by Michael.
> 
> Changes since v3:
>   - Reorder the acquire_privilege to avoid a possible
>     leak of privileges suggested by Eric.
> 
> Changes since v2:
>   - Overflow check improvement for time_ns from Eric.
> 
> Changes since v1:
>   - Make the macro for the offset between windows baseline
>     and Unix Epoch more readable from Eric.
>   - Overflow check for filetime pointed by Eric.
> 
> Lei Li (2):
>     qga: add windows implementation for guest-get-time
>     qga: add windows implementation for guest-set-time
>