From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGPwq-0000I0-HN for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:25:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGPwp-0000hQ-9k for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:25:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGPwp-0000gs-2P for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:25:07 -0400 Date: Fri, 15 Mar 2013 09:00:11 +0100 From: Kevin Wolf Message-ID: <20130315080011.GA2418@dhcp-200-207.str.redhat.com> References: <1363000996-13221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363000996-13221-2-git-send-email-xiawenc@linux.vnet.ibm.com> <513E1934.4030908@redhat.com> <513EB6B3.9050609@linux.vnet.ibm.com> <20130313124128.GG2309@dhcp-200-207.str.redhat.com> <87li9r9n8f.fsf@blackfin.pond.sub.org> <20130314090141.GB2485@dhcp-200-207.str.redhat.com> <87mwu6w5a4.fsf@blackfin.pond.sub.org> <20130314125334.GD2485@dhcp-200-207.str.redhat.com> <5142BE70.7020307@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5142BE70.7020307@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: lcapitulino@redhat.com, stefanha@gmail.com, pbonzini@redhat.com, Markus Armbruster , qemu-devel@nongnu.org Am 15.03.2013 um 07:23 hat Wenchao Xia geschrieben: > =E4=BA=8E 2013-3-14 20:53, Kevin Wolf =E5=86=99=E9=81=93: > >Am 14.03.2013 um 13:10 hat Markus Armbruster geschrieben: > >>Kevin Wolf writes: > >>>But you have to do it right. This specific patch would introduce a > >>>copyright violation. It's really not that hard to conform to the ter= ms > >>>of the MIT license, but that doesn't mean that you can ignore it. Th= ere > >>>is exactly one requirement and it reads like this: > >>> > >>> The above copyright notice and this permission notice shall be > >>> included in all copies or substantial portions of the Software. > >> > >>That's why I pointed to resources and examples on how to do it proper= ly. > >> > >>>(I'm still waiting for a patch to blockdev.c, for which you did it > >>>wrong, by the way) > >> > >>Oops, that one fell through the cracks. Patch coming. > > > >Thanks. > > > >>>>Of course, the stronger license still has to be compatible with GPL= v2, > >>>>so we can accept the result into QEMU. > >>>> > >>>>If a subsystem has additional requirements on licenses, its maintai= ners > >>>>will explain them to you. For what it's worth, substantial parts o= f the > >>>>block layer are already GPLv2+. > >>> > >>>What parts exactly? As long as there are plans for a libqblock and a= s > >>>long as it doesn't seem completely impossible to have it under LGPL,= I > >>>will ask to use either MIT or LGPL for block layer code (this doesn'= t > >>>apply to qemu-only code that isn't used in the tools - in this sense= , > >>>things like blockdev.c are not part of the block layer) > >> > >>$ git-grep -lw GPL block block* > >>block-migration.c > >>block/blkverify.c > >>block/gluster.c > >>block/linux-aio.c > >>block/raw-aio.h > >>block/rbd.c > >>block/sheepdog.c > >>blockdev-nbd.c > >>blockdev.c > > > >Luckily, none of these are really critical for a libqblock library, ev= en > >though they would be nice to have. > > > >If we can't license such a library as LGPL, we would lose the most > >important potential user, which is libvirt. In which case I probably > >wouldn't want to bother with providing a library at all. > > > >Kevin > > > As the discuss, I feel a direct copy of the license is the > easiest way, the original one is a good enough MIT license, if > my understanding is correct. > One more question: should the date be changed to 2003-2013 in > new file? >=20 > /* > * QEMU System Emulator > * > * Copyright (c) 2003-2008 Fabrice Bellard > ..... Probably not that important, but I would leave it as it is. Kevin