From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: use -nographic in test case 007
Date: Fri, 15 Mar 2013 09:31:05 +0100 [thread overview]
Message-ID: <20130315083105.GC2418@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1363277215-26776-1-git-send-email-stefanha@redhat.com>
Am 14.03.2013 um 17:06 hat Stefan Hajnoczi geschrieben:
> A comment explains that -nographic hangs test case 007. This is no
> longer the case so add -nographic. This makes the test suite faster and
> more pleasant to run since no windows pop up.
>
> I am not sure exactly when -nographic starting working for this case but
> there is no fundamental reason why graphics are needed here. Make sure
> the serial port is not on stdio, it would conflict with the monitor.
>
> Also remove unnecessary trailing whitespace on these lines.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This doesn't really make a difference for the speed on my laptop, but
it works and is definitely nicer. On my virtlab test box I noticed that
only this really enables the test. Before, it was complaining to
/dev/null that it couldn't open the display...
Tested-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2013-03-15 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 16:06 [Qemu-devel] [PATCH] qemu-iotests: use -nographic in test case 007 Stefan Hajnoczi
2013-03-15 8:31 ` Kevin Wolf [this message]
2013-03-15 10:02 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315083105.GC2418@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).