From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45492)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UGQ2g-0002Ak-Ud
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:31:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UGQ2e-0003EP-W2
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:31:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UGQ2e-0003E7-P9
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:31:08 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2F8V89q012334
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Mar 2013 04:31:08 -0400
Date: Fri, 15 Mar 2013 09:31:05 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130315083105.GC2418@dhcp-200-207.str.redhat.com>
References: <1363277215-26776-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363277215-26776-1-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: use -nographic in test case
	007
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org

Am 14.03.2013 um 17:06 hat Stefan Hajnoczi geschrieben:
> A comment explains that -nographic hangs test case 007.  This is no
> longer the case so add -nographic.  This makes the test suite faster and
> more pleasant to run since no windows pop up.
> 
> I am not sure exactly when -nographic starting working for this case but
> there is no fundamental reason why graphics are needed here.  Make sure
> the serial port is not on stdio, it would conflict with the monitor.
> 
> Also remove unnecessary trailing whitespace on these lines.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

This doesn't really make a difference for the speed on my laptop, but
it works and is definitely nicer. On my virtlab test box I noticed that
only this really enables the test. Before, it was complaining to
/dev/null that it couldn't open the display...

Tested-by: Kevin Wolf <kwolf@redhat.com>