From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGRTD-0003PE-IC for qemu-devel@nongnu.org; Fri, 15 Mar 2013 06:02:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGRT8-00033J-8B for qemu-devel@nongnu.org; Fri, 15 Mar 2013 06:02:39 -0400 Received: from mail-bk0-x22e.google.com ([2a00:1450:4008:c01::22e]:54835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGRT8-000332-15 for qemu-devel@nongnu.org; Fri, 15 Mar 2013 06:02:34 -0400 Received: by mail-bk0-f46.google.com with SMTP id j5so1449722bkw.33 for ; Fri, 15 Mar 2013 03:02:33 -0700 (PDT) Date: Fri, 15 Mar 2013 11:02:30 +0100 From: Stefan Hajnoczi Message-ID: <20130315100230.GB4436@stefanha-thinkpad.redhat.com> References: <1363277215-26776-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363277215-26776-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: use -nographic in test case 007 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org On Thu, Mar 14, 2013 at 05:06:55PM +0100, Stefan Hajnoczi wrote: > A comment explains that -nographic hangs test case 007. This is no > longer the case so add -nographic. This makes the test suite faster and > more pleasant to run since no windows pop up. > > I am not sure exactly when -nographic starting working for this case but > there is no fundamental reason why graphics are needed here. Make sure > the serial port is not on stdio, it would conflict with the monitor. > > Also remove unnecessary trailing whitespace on these lines. > > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/007 | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan