From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43104)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGZY7-0001mo-1n
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 14:40:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGZXw-00062s-UD
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 14:40:14 -0400
Received: from mail-qa0-f51.google.com ([209.85.216.51]:63995)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UGZXw-00061T-Pt
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 14:40:04 -0400
Received: by mail-qa0-f51.google.com with SMTP id cr7so479910qab.10
	for <qemu-devel@nongnu.org>; Fri, 15 Mar 2013 11:40:04 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Fri, 15 Mar 2013 13:36:43 -0500
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20130315183643.GA1580@vm>
References: <1363370871-10537-1-git-send-email-lersek@redhat.com>
	<1363370871-10537-3-git-send-email-lersek@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363370871-10537-3-git-send-email-lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] qga schema: document generic
	QERR_UNSUPPORTED
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Mar 15, 2013 at 07:07:51PM +0100, Laszlo Ersek wrote:
> Part of the wording was shamelessly stolen from Michael Roth's email.

:)

series:

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> 
> Suggested-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  qga/qapi-schema.json |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 2af3515..7155b7a 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -2,6 +2,17 @@
> 
>  ##
>  #
> +# General note concerning the use of guest agent interfaces:
> +#
> +# "unsupported" is a higher-level error than the errors that individual
> +# commands might document. The caller should always be prepared to receive
> +# QERR_UNSUPPORTED, even if the given command doesn't specify it, or doesn't
> +# document any failure mode at all.
> +#
> +##
> +
> +##
> +#
>  # Echo back a unique integer value, and prepend to response a
>  # leading sentinel byte (0xFF) the client can check scan for.
>  #
> -- 
> 1.7.1
>