From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHQSK-00027r-AC for qemu-devel@nongnu.org; Sun, 17 Mar 2013 23:09:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHQSC-0001nN-5F for qemu-devel@nongnu.org; Sun, 17 Mar 2013 23:09:48 -0400 Date: Mon, 18 Mar 2013 13:55:55 +1100 From: David Gibson Message-ID: <20130318025555.GF9402@truffula.fritz.box> References: <1363226008-26639-1-git-send-email-david@gibson.dropbear.id.au> <1363226008-26639-6-git-send-email-david@gibson.dropbear.id.au> <89E98310-17EE-4BFD-B8F6-A8FCC23FE5F1@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cz6wLo+OExbGG7q/" Content-Disposition: inline In-Reply-To: <89E98310-17EE-4BFD-B8F6-A8FCC23FE5F1@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] pseries: Move XICS initialization before cpu initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Michael Ellerman , Paul Mackerras , "qemu-ppc@nongnu.org list:PowerPC" , qemu-devel qemu-devel --cz6wLo+OExbGG7q/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2013 at 01:33:18PM +0100, Alexander Graf wrote: >=20 > On 14.03.2013, at 02:53, David Gibson wrote: >=20 > > Currently, the pseries machine initializes the cpus, then the XICS > > interrupt controller. However, to support the upcoming in-kernel XICS > > implementation we will need to initialize the irq controller before the > > vcpus. This patch makes the necesssary rearrangement. This means the >=20 > We're changing that notion in the in-kernel XICS discussions. The flow w= ill look like this: >=20 > * create vcpus > * create XICS > * foreach (vcpu) > * enable_cap(vcpu, CAP_XICS_SERVER, xics_handle) >=20 > However, that means we still need to know the maximum number of > supported vcpus during the create phase. That number can be bigger > than smp_cpus though, since you probably want to support hotplug add > of CPUs later on. >=20 > Can't we just make the number of supported "interrupt servers" a > constant? I suppose, but we need an allocation for each one, so its a bit ugly. In any case although the comment is a bit out of date, this patch also creates a logical place to put per-cpu XICS initialization which we will still need for the new interface. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --cz6wLo+OExbGG7q/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlFGgjsACgkQaILKxv3ab8a5VwCcD0BLS+zspAtM18On08XiI5RN xikAmwbA0EUpOp6FBnr52XGZ5hoa4Mq2 =gohW -----END PGP SIGNATURE----- --cz6wLo+OExbGG7q/--