[Qemu-devel] [PATCH] sheepdog: show error message for halt status

[Qemu-devel] [PATCH] sheepdog: show error message for halt status

[Liu Yuan]

From: Liu Yuan <tailai.ly@taobao.com>

Sheepdog (neither quorum nor unsafe mode) will refuse to serve IO requests when
number of alive nodes is less than that of copies specified by users. This will
return 0x19 to QEMU client which currently doesn't recognize it.

This patch adds an error description when QEMU client receives it, other than
plainly printing 'Invalid error code'

Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
---
 block/sheepdog.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/sheepdog.c b/block/sheepdog.c
index 4245328..54d3e53 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -65,6 +65,7 @@
 #define SD_RES_WAIT_FOR_FORMAT  0x16 /* Waiting for a format operation */
 #define SD_RES_WAIT_FOR_JOIN    0x17 /* Waiting for other nodes joining */
 #define SD_RES_JOIN_FAILED   0x18 /* Target node had failed to join sheepdog */
+#define SD_RES_HALT          0x19 /* Sheepdog is stopped serving IO request */
 
 /*
  * Object ID rules
@@ -344,6 +345,7 @@ static const char * sd_strerror(int err)
         {SD_RES_WAIT_FOR_FORMAT, "Sheepdog is waiting for a format operation"},
         {SD_RES_WAIT_FOR_JOIN, "Sheepdog is waiting for other nodes joining"},
         {SD_RES_JOIN_FAILED, "Target node had failed to join sheepdog"},
+        {SD_RES_HALT, "Sheepdog is stopped serving IO request"},
     };
 
     for (i = 0; i < ARRAY_SIZE(errors); ++i) {
-- 
1.7.9.5

Re: [Qemu-devel] [PATCH] sheepdog: show error message for halt status

[MORITA Kazutaka]

At Mon, 18 Mar 2013 14:27:55 +0800,
Liu Yuan wrote:
> 
> From: Liu Yuan <tailai.ly@taobao.com>
> 
> Sheepdog (neither quorum nor unsafe mode) will refuse to serve IO requests when
> number of alive nodes is less than that of copies specified by users. This will
> return 0x19 to QEMU client which currently doesn't recognize it.
> 
> This patch adds an error description when QEMU client receives it, other than
> plainly printing 'Invalid error code'
> 
> Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
>  block/sheepdog.c |    2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

Re: [Qemu-devel] [PATCH] sheepdog: show error message for halt status

[Stefan Hajnoczi]

On Mon, Mar 18, 2013 at 02:27:55PM +0800, Liu Yuan wrote:
> From: Liu Yuan <tailai.ly@taobao.com>
> 
> Sheepdog (neither quorum nor unsafe mode) will refuse to serve IO requests when
> number of alive nodes is less than that of copies specified by users. This will
> return 0x19 to QEMU client which currently doesn't recognize it.
> 
> This patch adds an error description when QEMU client receives it, other than
> plainly printing 'Invalid error code'
> 
> Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
>  block/sheepdog.c |    2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH] sheepdog: show error message for halt status

[Kevin Wolf]

Am 18.03.2013 um 07:27 hat Liu Yuan geschrieben:
> From: Liu Yuan <tailai.ly@taobao.com>
> 
> Sheepdog (neither quorum nor unsafe mode) will refuse to serve IO requests when
> number of alive nodes is less than that of copies specified by users. This will
> return 0x19 to QEMU client which currently doesn't recognize it.
> 
> This patch adds an error description when QEMU client receives it, other than
> plainly printing 'Invalid error code'
> 
> Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>

Thanks, applied to the block branch.

Kevin