From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHesx-0000H1-M5 for qemu-devel@nongnu.org; Mon, 18 Mar 2013 14:34:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHesv-0001A2-P0 for qemu-devel@nongnu.org; Mon, 18 Mar 2013 14:34:15 -0400 Received: from ssl.serverraum.org ([88.198.40.39]:52538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHesv-000192-HF for qemu-devel@nongnu.org; Mon, 18 Mar 2013 14:34:13 -0400 From: Michael Walle Date: Mon, 18 Mar 2013 19:33:47 +0100 References: <1362923278-4080-1-git-send-email-i.mitsyanko@gmail.com> <1362923278-4080-3-git-send-email-i.mitsyanko@gmail.com> In-Reply-To: <1362923278-4080-3-git-send-email-i.mitsyanko@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Message-Id: <201303181933.48069.michael@walle.cc> Subject: Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko Cc: andrew@openedhand.com, paul@codesourcery.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, peter.maydell@linaro.org Am Sonntag 10 M=E4rz 2013, 14:47:57 schrieb Igor Mitsyanko: > VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, > not for buffers allocated dynamically. Change to > VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. >=20 > Signed-off-by: Igor Mitsyanko > --- > hw/sd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/sd.c b/hw/sd.c > index 428bd78..88eaaf8 100644 > --- a/hw/sd.c > +++ b/hw/sd.c > @@ -478,7 +478,7 @@ static const VMStateDescription sd_vmstate =3D { > VMSTATE_UINT64(data_start, SDState), > VMSTATE_UINT32(data_offset, SDState), > VMSTATE_UINT8_ARRAY(data, SDState, 512), > - VMSTATE_BUFFER_UNSAFE(buf, SDState, 1, 512), > + VMSTATE_BUFFER_POINTER_UNSAFE(buf, SDState, 1, 512), > VMSTATE_BOOL(enable, SDState), > VMSTATE_END_OF_LIST() > } Tested-by: Michael Walle =2D-=20 michael