From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHs6P-0005eF-Mq for qemu-devel@nongnu.org; Tue, 19 Mar 2013 04:41:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHs6O-0008MZ-HH for qemu-devel@nongnu.org; Tue, 19 Mar 2013 04:41:01 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:56177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHs6O-0008MM-CG for qemu-devel@nongnu.org; Tue, 19 Mar 2013 04:41:00 -0400 Received: by mail-wi0-f178.google.com with SMTP id hq4so182725wib.11 for ; Tue, 19 Mar 2013 01:40:59 -0700 (PDT) Date: Tue, 19 Mar 2013 09:40:57 +0100 From: Stefan Hajnoczi Message-ID: <20130319084057.GB24393@stefanha-thinkpad.redhat.com> References: <1363653285-23776-1-git-send-email-asias@redhat.com> <1363653285-23776-4-git-send-email-asias@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363653285-23776-4-git-send-email-asias@redhat.com> Subject: Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Asias He Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Stefan Hajnoczi , Paolo Bonzini On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: > --- > hw/vhost.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/vhost.c b/hw/vhost.c > index 4d6aee3..0c52ec4 100644 > --- a/hw/vhost.c > +++ b/hw/vhost.c > @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener *listener, > return; > } > > +#if 0 > if (dev->started) { > r = vhost_verify_ring_mappings(dev, start_addr, size); > assert(r >= 0); > } > +#endif Please add a comment to explain why. Stefan