* [Qemu-devel] [PATCH 1/3] Revert "block: complete all IOs before .bdrv_truncate"
@ 2013-03-11 10:03 Peter Lieven
2013-03-19 13:10 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Peter Lieven @ 2013-03-11 10:03 UTC (permalink / raw)
To: qemu-devel@nongnu.org
Cc: Kevin Wolf, Paolo Bonzini, Jeff Cody, Anthony Liguori
brdv_truncate() is also called from readv/writev commands on self-
growing file based storage. this will result in requests waiting
for theirselves to complete.
This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33.
---
block.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block.c b/block.c
index 124a9eb..60c246a 100644
--- a/block.c
+++ b/block.c
@@ -2449,10 +2449,6 @@ int bdrv_truncate(BlockDriverState *bs, int64_t offset)
return -EACCES;
if (bdrv_in_use(bs))
return -EBUSY;
-
- /* There better not be any in-flight IOs when we truncate the device. */
- bdrv_drain_all();
-
ret = drv->bdrv_truncate(bs, offset);
if (ret == 0) {
ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] Revert "block: complete all IOs before .bdrv_truncate"
2013-03-11 10:03 [Qemu-devel] [PATCH 1/3] Revert "block: complete all IOs before .bdrv_truncate" Peter Lieven
@ 2013-03-19 13:10 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2013-03-19 13:10 UTC (permalink / raw)
To: Peter Lieven
Cc: Paolo Bonzini, Jeff Cody, qemu-devel@nongnu.org, Anthony Liguori
Am 11.03.2013 um 11:03 hat Peter Lieven geschrieben:
> brdv_truncate() is also called from readv/writev commands on self-
> growing file based storage. this will result in requests waiting
> for theirselves to complete.
>
> This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33.
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-19 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 10:03 [Qemu-devel] [PATCH 1/3] Revert "block: complete all IOs before .bdrv_truncate" Peter Lieven
2013-03-19 13:10 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).