From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHwon-00085u-Cl for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:43:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHwof-00068b-Kp for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:43:09 -0400 Date: Tue, 19 Mar 2013 14:42:58 +0100 From: Kevin Wolf Message-ID: <20130319134258.GE2418@dhcp-200-207.str.redhat.com> References: <1363692343-22299-1-git-send-email-kwolf@redhat.com> <51486831.4070802@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <51486831.4070802@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] serial: Fix debug format strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-trivial , qemu-devel@nongnu.org Am 19.03.2013 um 14:29 hat Andreas F=E4rber geschrieben: > Am 19.03.2013 12:25, schrieb Kevin Wolf: > > This fixes the build of hw/serial.c with DEBUG_SERIAL enabled. > >=20 > > Signed-off-by: Kevin Wolf > > --- > > hw/serial.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/hw/serial.c b/hw/serial.c > > index 48a5eb6..0ccc499 100644 > > --- a/hw/serial.c > > +++ b/hw/serial.c > > @@ -306,7 +306,7 @@ static void serial_ioport_write(void *opaque, hwa= ddr addr, uint64_t val, > > SerialState *s =3D opaque; > > =20 > > addr &=3D 7; > > - DPRINTF("write addr=3D0x%02x val=3D0x%02x\n", addr, val); > > + DPRINTF("write addr=3D0x%" HWADDR_PRIx " val=3D0x%" PRIx64 "\n",= addr, val); >=20 > Are you intentionally dropping 02 in both places? That changes output F= WIW. %02 for 64 bit values felt odd, but I think they might be guaranteed to be small enough in practice. If you really prefer, I can send a v2 which adds it back. But it's only debug code, so... *shrug* Kevin