From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIEk2-0005V4-4u for qemu-devel@nongnu.org; Wed, 20 Mar 2013 04:51:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIEk0-0003dH-Jj for qemu-devel@nongnu.org; Wed, 20 Mar 2013 04:51:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIEk0-0003c6-C3 for qemu-devel@nongnu.org; Wed, 20 Mar 2013 04:51:24 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2K8pNbO031749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Mar 2013 04:51:23 -0400 Date: Wed, 20 Mar 2013 09:51:21 +0100 From: Kevin Wolf Message-ID: <20130320085121.GC3074@dhcp-200-207.str.redhat.com> References: <1363627441-8297-1-git-send-email-kwolf@redhat.com> <1363627441-8297-9-git-send-email-kwolf@redhat.com> <514919D2.5050403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <514919D2.5050403@redhat.com> Subject: Re: [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Am 20.03.2013 um 03:07 hat Eric Blake geschrieben: > On 03/18/2013 11:23 AM, Kevin Wolf wrote: > > bdrv_open() uses two different variables called options. Rename one of > > them to avoid confusion and to allow the outer one to be accessed > > everywhere. > > > > Signed-off-by: Kevin Wolf > > --- > > block.c | 16 +++++++++------- > > 1 file changed, 9 insertions(+), 7 deletions(-) > > Reviewed-by: Eric Blake > > Should configure be setting up -Wshadow to help prevent instances like this? Perhaps it should. But I tried it out and there are by far too many warnings, so that doing this patch wouldn't be a trivial task. Kevin