From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIIG7-0000Ll-NN for qemu-devel@nongnu.org; Wed, 20 Mar 2013 08:36:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIIG4-00080I-0G for qemu-devel@nongnu.org; Wed, 20 Mar 2013 08:36:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIIG3-00080A-Ni for qemu-devel@nongnu.org; Wed, 20 Mar 2013 08:36:43 -0400 Date: Wed, 20 Mar 2013 13:36:25 +0100 From: Stefan Hajnoczi Message-ID: <20130320123625.GA14441@stefanha-thinkpad.muc.redhat.com> References: <1363770002-4521-1-git-send-email-fred.konrad@greensocs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363770002-4521-1-git-send-email-fred.konrad@greensocs.com> Subject: Re: [Qemu-devel] [PATCH] virtio-blk-x: fix configuration synchronization. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com On Wed, Mar 20, 2013 at 10:00:01AM +0100, fred.konrad@greensocs.com wrote: > From: KONRAD Frederic > > The virtio-blk-x configuration is not in sync with virtio-blk configuration. > So this patch remove the virtio-blk-x configuration field, and use virtio-blk > one for setting the properties. > > This also remove a useless configuration copy in virtio_blk_device_init. > > Note that this is on top of "virtio-ccw queue as of 2013/03/20". Look fine, although I haven't looked into the latest virtio-ccw or virtio-blk refactoring. Stefan