From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UILLI-0005nt-QM for qemu-devel@nongnu.org; Wed, 20 Mar 2013 11:54:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UILLG-0005SY-5A for qemu-devel@nongnu.org; Wed, 20 Mar 2013 11:54:20 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:36616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UILLF-0005OP-Tv for qemu-devel@nongnu.org; Wed, 20 Mar 2013 11:54:18 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Mar 2013 15:51:52 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 32280219002D for ; Wed, 20 Mar 2013 15:55:57 +0000 (GMT) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2KFs4Qh48693324 for ; Wed, 20 Mar 2013 15:54:04 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2KFsCwd027112 for ; Wed, 20 Mar 2013 09:54:13 -0600 Date: Wed, 20 Mar 2013 16:54:11 +0100 From: Cornelia Huck Message-ID: <20130320165411.1f6e1da0@gondolin> In-Reply-To: <1363788463-27462-1-git-send-email-fred.konrad@greensocs.com> References: <1363788463-27462-1-git-send-email-fred.konrad@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 00/10] virtio-scsi refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org On Wed, 20 Mar 2013 15:07:33 +0100 fred.konrad@greensocs.com wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-scsi device which extends virtio-device. > Then a virtio-scsi can be connected on a virtio-bus. > virtio-scsi-pci, virtio-scsi-s390x, virtio-scsi-ccw are created too, they extend > respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a > virtio-scsi. > > You can checkout my branch here: > > git://project.greensocs.com/qemu-virtio.git virtio-scsi-v4 I have not looked at the code yet, but with this tree I can create virtio-scsi-ccw and virtio-scsi-s390 devices that look sane at first glance. On virtio-ccw, the device also detaches without creating a hiccup in qemu. > > Note that it is nearly the same series as virtio-blk refactoring. Though the 2nd > and the 3rd steps are a virtio-scsi specific. > > I made basic tests (with linux guests) on: > * qemu-system-i386 > > Changes v3 -> v4: > * Added CCW device. > * Fixed the configuration issue. > > Thanks, > > Fred > > KONRAD Frederic (10): > virtio-scsi: don't use pointer for configuration. > virtio-scsi: allocate cmd_vqs array separately. > virtio-scsi: moving host_features from properties to transport > properties. > virtio-scsi: add the virtio-scsi device. > virtio-scsi-pci: switch to new API. > virtio-scsi-s390: switch to the new API. > virtio-scsi-ccw: switch to new API > virtio-scsi: cleanup: use QOM casts. > virtio-scsi: cleanup: init and exit functions. > virtio-scsi: cleanup: remove qdev field. > > hw/s390x/s390-virtio-bus.c | 30 ++++++++--- > hw/s390x/s390-virtio-bus.h | 11 +++- > hw/s390x/virtio-ccw.c | 32 +++++++----- > hw/s390x/virtio-ccw.h | 12 ++++- > hw/virtio-pci.c | 119 ++++++++++++++++++++++--------------------- > hw/virtio-pci.h | 15 +++++- > hw/virtio-scsi.c | 122 ++++++++++++++++++++++++++++++--------------- > hw/virtio-scsi.h | 21 ++++---- > 8 files changed, 230 insertions(+), 132 deletions(-) >